Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-11712 - Avoid write lock on disconnect unless neeeded #6120

Merged
merged 1 commit into from Jun 26, 2014

Conversation

@jakesmith
Copy link
Member

jakesmith commented Jun 24, 2014

A connection disconnect was grabbing an exclusive lock to the
shared dataRWLock unconditionally, when it only needed it if it
was altering the store. This was causing extra contention and
thread serialization.

Signed-off-by: Jake Smith jake.smith@lexisnexis.com

A connection disconnect was grabbing an exclusive lock to the
shared dataRWLock unconditionally, when it only needed it if it
was altering the store. This was causing extra contention and
thread serialization.

Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
@hpcc-jirabot

This comment has been minimized.

Copy link

hpcc-jirabot commented Jun 24, 2014

Jira updated

@jakesmith

This comment has been minimized.

Copy link
Member Author

jakesmith commented Jun 24, 2014

@ghalliday - please review

@richardkchapman

This comment has been minimized.

Copy link
Member

richardkchapman commented Jun 26, 2014

typo (neeeeeeded) in commit message

connection->queryParent()->removeTree(tree);
else
deleteRoot |= unlock(tree->queryServerId(), id);
if (!deleteRoot && unlock(tree->queryServerId(), id, true)) // unlock returns true if last unlock and there was a setDROLR on it

This comment has been minimized.

Copy link
@ghalliday

ghalliday Jun 26, 2014

Member

Where is the setDROLR checked?

This comment has been minimized.

Copy link
@jakesmith

jakesmith Jun 26, 2014

Author Member

It's checked in CLockInfo::unlock (setDROLR sets 'parent')

@ghalliday

This comment has been minimized.

Copy link
Member

ghalliday commented Jun 26, 2014

@richardkchapman the change looks good.

richardkchapman added a commit that referenced this pull request Jun 26, 2014
HPCC-11712 - Avoid write lock on disconnect unless needed

Reviewed-By: Gavin Halliday <gavin.halliday@lexisnexis.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
@richardkchapman richardkchapman merged commit 07bdd7c into hpcc-systems:candidate-4.2.6 Jun 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.