Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-11993 Add URL fetch for bundle install #6618

Merged
merged 2 commits into from Nov 7, 2014

Conversation

@richardkchapman
Copy link
Member

richardkchapman commented Nov 7, 2014

ecl-bundle can now accept a url in place of a filename.

If the url ends in .git, it is assumed to be a git repository (fetched using
git clone), otherwise it is assumed to be the url of a file that can be
retrived via curl.

In both cases the file/repository is fetched to a temporary local location,
processed as a local file/directory would be, then removed.

Signed-off-by: Richard Chapman rchapman@hpccsystems.com

ecl-bundle can now accept a url in place of a filename.

If the url ends in .git, it is assumed to be a git repository (fetched using
git clone), otherwise it is assumed to be the url of a file that can be
retrived via curl.

In both cases the file/repository is fetched to a temporary local location,
processed as a local file/directory would be, then removed.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
@hpcc-jirabot

This comment has been minimized.

Copy link

hpcc-jirabot commented Nov 7, 2014

Jira updated

@richardkchapman

This comment has been minimized.

Copy link
Member Author

richardkchapman commented Nov 7, 2014

@ghalliday Please review

@richardkchapman

This comment has been minimized.

Copy link
Member Author

richardkchapman commented Nov 7, 2014

Also please see hpcc-systems/ecl-bundles#32

@@ -1 +1 @@
set ( CPACK_DEBIAN_PACKAGE_DEPENDS "libboost-regex1.46.1, libicu48, libxalan110, libxerces-c28, binutils, libldap-2.4-2, openssl, zlib1g, g++, openssh-client, openssh-server, expect, libarchive12, rsync, libapr1, libaprutil1, zip")
set ( CPACK_DEBIAN_PACKAGE_DEPENDS "libboost-regex1.46.1, libicu48, libxalan110, libxerces-c28, binutils, libldap-2.4-2, openssl, zlib1g, g++, openssh-client, openssh-server, expect, libarchive12, rsync, libapr1, libaprutil1, zip, libcurl3")

This comment has been minimized.

Copy link
@ghalliday

ghalliday Nov 7, 2014

Member

Do we also need the dependencies for the other platforms?

This comment has been minimized.

Copy link
@richardkchapman

richardkchapman Nov 7, 2014

Author Member

No, actually we should not have this one any more (since I switched back from using libcurl to using the curl executable).

I don't want to make curl a dependency - we run fine without it (just can't use this particular feature)

Licensing issues with libcurl are too confusing. Use curl executable instead,
and simply fail if it can't be run.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
@richardkchapman richardkchapman force-pushed the richardkchapman:bundle-curl branch from 76a6c2f to 17007aa Nov 7, 2014
ghalliday added a commit that referenced this pull request Nov 7, 2014
HPCC-11993 Add URL fetch for bundle install

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
@ghalliday ghalliday merged commit 58c95b7 into hpcc-systems:master Nov 7, 2014
@richardkchapman richardkchapman deleted the richardkchapman:bundle-curl branch Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.