HPCC-14474 Improve testing of sorts #7929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add random, sorted, reverse sorted tests, and check results are sorted, and sorting is stable. Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
|
https://track.hpccsystems.com/browse/HPCC-14474 |
|
See also hpcc-systems/ecl-bundles#39 |
|
@richardkchapman please review |
|
Automated Smoketest Build: success
sort3 on hthor failed with:
9: Test: sortfwd:ecl ( version: algo=tbbstableqsort )
--- sortfwd:xml
+++ sortfwd:xml
@@ -1,3 +1,4 @@
+<Warning><Code>5403</Code><Source>hthor</Source><Message>Ignoring unsupported sort order algorithm 'tbbstableqsort', using default</Message></Warning>
<Dataset name=Result 1>
<Row><Result_1>true</Result_1></Row>
</Dataset>
HPCC Stop: OK |
|
Note: The PR for the merge sort changes includes the new tbbsort implementation. |
|
@AttilaVamos the error has been associated with the wrong test |
|
@ghalliday I'm working on the error report fix. |
|
Automated Smoketest Build: success
sortfwd(algo=tbbstableqsort ) on hthor failed with:
--- sortfwd:xml
+++ sortfwd:xml
@@ -1,3 +1,4 @@
+<Warning><Code>5403</Code><Source>hthor</Source><Message>Ignoring unsupported sort order algorithm 'tbbstableqsort', using default</Message></Warning>
<Dataset name=Result 1>
<Row><Result_1>true</Result_1></Row>
</Dataset>
sortnorm(algo=tbbstableqsort ) on hthor failed with:
--- sortnorm:xml
+++ sortnorm:xml
@@ -1,3 +1,4 @@
+<Warning><Code>5403</Code><Source>hthor</Source><Message>Ignoring unsupported sort order algorithm 'tbbstableqsort', using default</Message></Warning>
<Dataset name=Result 1>
<Row><Result_1>true</Result_1></Row>
</Dataset>
sortrev(algo=tbbstableqsort ) on hthor failed with:
--- sortrev:xml
+++ sortrev:xml
@@ -1,3 +1,4 @@
+<Warning><Code>5403</Code><Source>hthor</Source><Message>Ignoring unsupported sort order algorithm 'tbbstableqsort', using default</Message></Warning>
<Dataset name=Result 1>
<Row><Result_1>true</Result_1></Row>
</Dataset>
sortstable(algo=tbbstableqsort ) on hthor failed with:
--- sortstable:xml
+++ sortstable:xml
@@ -1,3 +1,4 @@
+<Warning><Code>5403</Code><Source>hthor</Source><Message>Ignoring unsupported sort order algorithm 'tbbstableqsort', using default</Message></Warning>
<Dataset name=Result 1>
<Row><Result_1>true</Result_1></Row>
</Dataset>
HPCC Stop: OK |
|
@AttilaVamos that is better. |
|
What if anything are we planning to do about those warnings? |
|
@ghalliday One question |
|
When my sort change (#7922) is merged in they will go away. |
|
@richardkchapman replied |
richardkchapman
added a commit
that referenced
this pull request
Nov 13, 2015
HPCC-14474 Improve testing of sorts Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add random, sorted, reverse sorted tests, and check results
are sorted, and sorting is stable.
Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com