HPCC-14586 Support HINT on COUNT() and DATASET([]) #7991
Conversation
|
https://track.hpccsystems.com/browse/HPCC-14586 |
|
Automated Smoketest Build: success |
ghalliday
force-pushed
the
issue14586
branch
from
2a75b27
to
9326c04
Compare
|
Automated Smoketest Build: success |
|
@jamienoss please review |
| ForEachChild(i2, expr) | ||
| { | ||
| IHqlExpression * cur = expr->queryChild(i2); | ||
| if (cur->isAttribute()) |
There was a problem hiding this comment.
Is it ok/intended to include the keyed attribute even though this is already/also included in valueArgs? Not sure if the only point to this loop is to ensure all attributes are preserved where they were ignored from valueArgs or...?
There was a problem hiding this comment.
Yes, it is desired. Ideally keyed would not be added to the valueArgs, but that would require more substantial changes elsewhere.
|
@ghalliday back to you. |
|
@richardkchapman please review |
|
and merge if happy. |
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
|
Automated Smoketest Build: success |
HPCC-14586 Support HINT on COUNT() and DATASET([]) Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com