Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-16222 Grid always opens last file in the list #9121

Merged
merged 1 commit into from Sep 19, 2016

Conversation

miguelvazq
Copy link

Whenever a user is clicking on any row within QuerySetLogicalFiles the last row always opens due to an undefined id in the createDetail call.

Signed-off by: Miguel Vazquez miguel.vazquez@lexisnexis.com

Whenever a user is clicking on any row within QuerySetLogicalFiles the last row always opens due to an undefined id in the createDetail call.

Signed-off by: Miguel Vazquez <miguel.vazquez@lexisnexis.com>
@hpcc-jirabot
Copy link

https://track.hpccsystems.com/browse/HPCC-16222
Jira not updated (state was not active or new)

@miguelvazq
Copy link
Author

@GordonSmith Please review.

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest
Sha: 1e1fdb8
Build: success
Install hpccsystems-platform-community_6.1.0-trunk0.el6.x86_64.rpm
HPCC Start: OK
Unittest result: total:83 passed:83 failed:0

HPCC Stop: OK
HPCC Uninstall: OK

Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@richardkchapman
Copy link
Member

This looks like it might make sense in a 6.0.6 build?

@richardkchapman
Copy link
Member

@GordonSmith What do you think?

@GordonSmith
Copy link
Member

I agree

@richardkchapman richardkchapman merged commit 7927475 into hpcc-systems:master Sep 19, 2016
@richardkchapman
Copy link
Member

Merged to master and cherry-picked to 6.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants