Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-17132 DOCS:ConfigMgr can use IP or Hostnames #9700

Merged

Conversation

@g-pan
Copy link
Member

g-pan commented Mar 15, 2017

Fix HPCC-17132 DOCS:ConfigMgr can use IP or Hostnames
Document that we can use IP addresses of the host names
in configuring the HPCC.

@rpastrana please review
@JamesDeFabia please review

Signed-off-by: G-Pan greg.panagiotatos@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browers
    • The component(s) render as expected

Testing:

Tested by building the changed documents. All built successfully.

@hpcc-jirabot

This comment has been minimized.

Copy link

hpcc-jirabot commented Mar 15, 2017

Copy link
Member

rpastrana left a comment

@g-pan some minor comments

@@ -894,8 +894,8 @@
<listitem>
<?dbfo keep-together="always"?>

<para>Enter the all the IP addresses you want to use in this
HPCC.</para>
<para>Enter the all the IP addresses you want to use in this HPCC.

This comment has been minimized.

Copy link
@rpastrana

rpastrana Mar 15, 2017

Member

The original sentence needs to be reworded (there's an extra 'the'). Also, I think it should be hostnames

@@ -912,9 +912,6 @@
<para>Press the <emphasis role="bold">Next</emphasis>
button.</para>

<para>Alternatively, you could find the IP addresses using Auto

This comment has been minimized.

Copy link
@rpastrana

rpastrana Mar 15, 2017

Member

Not related to this issue.

This comment has been minimized.

Copy link
@g-pan

g-pan Mar 16, 2017

Author Member

Addressed in #9703
only not merged yet, Removed this bit to ensure the text does not get reintroduced.

@@ -163,13 +163,14 @@
<listitem>
<?dbfo keep-together="always"?>

<para>Enter the IP addresses.</para>
<para>Enter the IP addresses or host names. </para>

This comment has been minimized.

Copy link
@rpastrana

rpastrana Mar 15, 2017

Member

let's use hostnames

@rpastrana

This comment has been minimized.

Copy link
Member

rpastrana commented Mar 15, 2017

The "add hardware" interface documentation should also be updated.

@richardkchapman

This comment has been minimized.

Copy link
Member

richardkchapman commented Mar 16, 2017

@g-pan Back to you

@rpastrana

This comment has been minimized.

Copy link
Member

rpastrana commented Mar 16, 2017

@g-pan squash these commits, and update the "add hardware" screen documentation.

@richardkchapman

This comment has been minimized.

Copy link
Member

richardkchapman commented Mar 17, 2017

Fix HPCC-17132 DOCS:ConfigMgr can use IP or Hostnames
Document that we can use IP addresses of the host names
in configuring the HPCC.

Signed-off-by: G-Pan <greg.panagiotatos@lexisnexis.com>
@g-pan g-pan force-pushed the g-pan:H17132-CfgHostnames branch from 0626c09 to 74f04f8 Mar 21, 2017
@g-pan

This comment has been minimized.

Copy link
Member Author

g-pan commented Mar 21, 2017

Comments addressed. Squashed and rebased.

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

HPCCSmoketest commented Mar 21, 2017

Automated Smoketest:
Sha: 74f04f8
Build: success
ECL Watch: Rebuilding Site

errors warnings build time
0 65 93.432 seconds

Install hpccsystems-platform-community_6.3.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 93 93 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

HPCC Stop: OK
HPCC Uninstall: OK

@g-pan

This comment has been minimized.

Copy link
Member Author

g-pan commented Mar 21, 2017

@rpastrana please review

@rpastrana

This comment has been minimized.

Copy link
Member

rpastrana commented Mar 21, 2017

@g-pan changes look fine. I did not confirm all necessary sections were updated.

@richardkchapman richardkchapman merged commit 86eec0c into hpcc-systems:candidate-6.4.0 Mar 22, 2017
@g-pan g-pan deleted the g-pan:H17132-CfgHostnames branch May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.