Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-17578 Fix implicit project of THOR(no_compound) #9969

Merged
merged 1 commit into from May 12, 2017

Conversation

Projects
None yet
5 participants
@ghalliday
Copy link
Member

commented May 10, 2017

Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browers
    • The component(s) render as expected

Testing:

Ran full compiler regression test (no changes) and checked it fixed new example issue17578 in private suite.

HPCC-17578 Fix implicit project of THOR(no_compound)
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
@hpcc-jirabot

This comment has been minimized.

Copy link

commented May 10, 2017

@ghalliday

This comment has been minimized.

Copy link
Member Author

commented May 10, 2017

@shamser please review

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

commented May 10, 2017

Automated Smoketest:
Sha: dd5ae70
Build: success
Build: success
ECL Watch: Rebuilding Site

errors warnings build time
0 65 93.825 seconds

Install hpccsystems-platform-community_6.3.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 93 93 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 10 10 0
setup (thor) 10 10 0
setup (roxie) 10 10 0
test (hthor) 727 727 0
test (thor) 621 621 0
test (roxie) 748 748 0

HPCC Stop: OK
HPCC Uninstall: OK

@shamser

This comment has been minimized.

Copy link
Contributor

commented May 11, 2017

@ghalliday You mentioned you added tests to cover the changes. There doesn't seem to be any test programs committed. Is there one?

@ghalliday

This comment has been minimized.

Copy link
Member Author

commented May 11, 2017

@shamser the test is checked into the private suite - see issue17578.eclxml

@shamser
Copy link
Contributor

left a comment

@ghalliday Code reviewed ok.

@richardkchapman richardkchapman merged commit dbab971 into hpcc-systems:candidate-6.4.0 May 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.