Adds Multiselect to the Table Widget #437
Merged
Conversation
src/other/Table.css
Outdated
| @@ -26,8 +26,13 @@ | |||
| color:black; | |||
| } | |||
|
|
|||
| .other_Table .selected { | |||
GordonSmith
May 28, 2015
Member
I would change this to: .other_Table tr.selected
I would change this to: .other_Table tr.selected
src/other/Table.js
Outdated
| rows | ||
| .attr("class", function (d) { | ||
| // alert(this); | ||
| // alert(d); |
GordonSmith
May 28, 2015
Member
Remove commented code
Remove commented code
src/other/Table.js
Outdated
| } else { | ||
| var t = []; | ||
| for (var i = 0; i < _.length; i++) { | ||
| t[i] = { |
mzummo
May 28, 2015
Contributor
i'd do the indent on this obj and the others a bit different? But i am not sure if this is a standard way of doing so? I 4 space indent everything
i'd do the indent on this obj and the others a bit different? But i am not sure if this is a standard way of doing so? I 4 space indent everything
|
Code looks fine. From a learning point of view, take a look at: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/map It exists specifically to transform an array of objects to anouther array shape... |
Fixes GH-427 Signed-off-by: Anmol Jagetia <anmoljagetia@gmail.com>
|
Looks good. |
GordonSmith
added a commit
that referenced
this pull request
May 29, 2015
Adds Multiselect to the Table Widget
GordonSmith
merged commit 3a8a2f6
into
hpcc-systems:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
@GordonSmith @mlzummo Please review!
Fixes GH-427
Signed-off-by: Anmol Jagetia anmoljagetia@gmail.com