New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Multiselect to the Table Widget #437

Merged
merged 1 commit into from May 29, 2015

Conversation

Projects
None yet
3 participants
@anmoljagetia
Contributor

anmoljagetia commented May 28, 2015

@GordonSmith @mlzummo Please review!
Fixes GH-427
Signed-off-by: Anmol Jagetia anmoljagetia@gmail.com

@@ -26,8 +26,13 @@
color:black;
}
.other_Table .selected {

This comment has been minimized.

@GordonSmith

GordonSmith May 28, 2015

Member

I would change this to: .other_Table tr.selected

rows
.attr("class", function (d) {
// alert(this);
// alert(d);

This comment has been minimized.

@GordonSmith

GordonSmith May 28, 2015

Member

Remove commented code

} else {
var t = [];
for (var i = 0; i < _.length; i++) {
t[i] = {

This comment has been minimized.

@mzummo

mzummo May 28, 2015

Contributor

i'd do the indent on this obj and the others a bit different? But i am not sure if this is a standard way of doing so? I 4 space indent everything

@GordonSmith

This comment has been minimized.

Member

GordonSmith commented May 28, 2015

Code looks fine. From a learning point of view, take a look at: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/map It exists specifically to transform an array of objects to anouther array shape...

@anmoljagetia anmoljagetia force-pushed the anmoljagetia:tableSelect branch from 7751470 to 0258ef1 May 29, 2015

Adds Multiselect to the Table Widget
Fixes GH-427

Signed-off-by: Anmol Jagetia <anmoljagetia@gmail.com>

@anmoljagetia anmoljagetia force-pushed the anmoljagetia:tableSelect branch from 0258ef1 to d508549 May 29, 2015

@GordonSmith

This comment has been minimized.

Member

GordonSmith commented May 29, 2015

Looks good.

GordonSmith added a commit that referenced this pull request May 29, 2015

Merge pull request #437 from anmoljagetia/tableSelect
Adds Multiselect to the Table Widget

@GordonSmith GordonSmith merged commit 3a8a2f6 into hpcc-systems:master May 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment