New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for unit test and Adds a widget loading test #663

Merged
merged 1 commit into from Aug 9, 2015

Conversation

Projects
None yet
2 participants
@anmoljagetia
Contributor

anmoljagetia commented Aug 8, 2015

Adds a unit test to check loading of widgets.
Signed-off-by: Anmol Jagetia anmoljagetia@gmail.com

@anmoljagetia anmoljagetia force-pushed the anmoljagetia:unitTest branch 2 times, most recently from 252ff2c to 2797160 Aug 8, 2015

@anmoljagetia anmoljagetia force-pushed the anmoljagetia:unitTest branch from 2797160 to 44aef9b Aug 9, 2015

@GordonSmith

This comment has been minimized.

Member

GordonSmith commented Aug 9, 2015

Can you change commit message to something like:

GH-665 Add Unit Tests

Add unitTesting using mocha, chai and phantomjs.

Fixes GH-665

@anmoljagetia anmoljagetia force-pushed the anmoljagetia:unitTest branch 2 times, most recently from 2aa169a to 41624c7 Aug 9, 2015

gulpfile.js Outdated
gulp.task('unitTest', function () {
return gulp
.src(cfg.test + '/runner.html') // This will fail if any HTML file has a BOM.
.pipe(mochaPhantomJS({ reporter: 'spec' }))

This comment has been minimized.

@GordonSmith

GordonSmith Aug 9, 2015

Member

Switch to using the "dot" reporter

@@ -5,4 +5,5 @@ before_script:
- npm install -g bower

This comment has been minimized.

@GordonSmith

GordonSmith Aug 9, 2015

Member

Can you also add "sudo: false" to the first line this file?

@anmoljagetia anmoljagetia force-pushed the anmoljagetia:unitTest branch 2 times, most recently from da84bc4 to 550d10f Aug 9, 2015

GH-665 Add Unit Tests
Add unitTesting using mocha, chai and phantomjs.

Fixes GH-665

Signed-off-by: Anmol Jagetia <anmoljagetia@gmail.com>

@anmoljagetia anmoljagetia force-pushed the anmoljagetia:unitTest branch from 550d10f to 4d386f6 Aug 9, 2015

@GordonSmith

This comment has been minimized.

Member

GordonSmith commented Aug 9, 2015

Looks good.

GordonSmith added a commit that referenced this pull request Aug 9, 2015

Merge pull request #663 from anmoljagetia/unitTest
Adds support for unit test and Adds a widget loading test

@GordonSmith GordonSmith merged commit 73ca574 into hpcc-systems:master Aug 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment