Adds code validation to the Framework #675
Merged
Conversation
gulpfile.js
Outdated
| @@ -86,6 +87,15 @@ gulp.task('build-css', css.bind(null, false)); | |||
|
|
|||
| gulp.task('optimize-css', css.bind(null, true)); | |||
|
|
|||
| gulp.task('jscs', function() { | |||
| gutil.log("JSCS the files...." + '\n'); | |||
| var lintFilter = filter(["**", "!config.js", "!map/us-counties.js", "!map/us-states.js", "!map/countries.js"]); | |||
GordonSmith
Aug 10, 2015
Member
Move lintFilter out of task so it can be reused in lint and jscs
Move lintFilter out of task so it can be reused in lint and jscs
anmoljagetia
Aug 10, 2015
Author
Contributor
I am assuming there will be different files in them at a later point. (I am unsure of it, right now, so for now, should I move them out?)
I am assuming there will be different files in them at a later point. (I am unsure of it, right now, so for now, should I move them out?)
GordonSmith
Aug 10, 2015
Member
I am 99% sure that the same list will be used for both.
I am 99% sure that the same list will be used for both.
|
jscs should also be called from "test" |
|
Can you roll up to one commit |
Signed-off-by: Anmol Jagetia <anmoljagetia@gmail.com>
GordonSmith
added a commit
that referenced
this pull request
Aug 11, 2015
Adds code validation to the Framework
GordonSmith
merged commit 83d13ae
into
hpcc-systems:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Presently, there are no rules in the .jscsrc file, but we can add more, and ensure coding guidelines. In a seperate PR, I'll be working to fix the quotemark rule.