Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
GordonSmith
reviewed
Aug 10, 2015
gulpfile.js
Outdated
| @@ -86,6 +87,15 @@ gulp.task('build-css', css.bind(null, false)); | ||
| gulp.task('optimize-css', css.bind(null, true)); | ||
| gulp.task('jscs', function() { | ||
| gutil.log("JSCS the files...." + '\n'); | ||
| var lintFilter = filter(["**", "!config.js", "!map/us-counties.js", "!map/us-states.js", "!map/countries.js"]); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
anmoljagetia
Aug 10, 2015
Contributor
I am assuming there will be different files in them at a later point. (I am unsure of it, right now, so for now, should I move them out?)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
jscs should also be called from "test" |
This comment has been minimized.
This comment has been minimized.
|
Can you roll up to one commit |
anmoljagetia
force-pushed the
anmoljagetia:quoteRule
branch
from
e784508
to
f8377bb
Aug 10, 2015
anmoljagetia
force-pushed the
anmoljagetia:quoteRule
branch
from
f8377bb
to
bfc5a4b
Aug 10, 2015
added a commit
that referenced
this pull request
Aug 11, 2015
GordonSmith
merged commit 83d13ae
into
hpcc-systems:master
Aug 11, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
anmoljagetia commentedAug 10, 2015
Presently, there are no rules in the .jscsrc file, but we can add more, and ensure coding guidelines. In a seperate PR, I'll be working to fix the quotemark rule.