New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds code validation to the Framework #675

Merged
merged 1 commit into from Aug 11, 2015

Conversation

Projects
None yet
2 participants
@anmoljagetia
Contributor

anmoljagetia commented Aug 10, 2015

Presently, there are no rules in the .jscsrc file, but we can add more, and ensure coding guidelines. In a seperate PR, I'll be working to fix the quotemark rule.

gulpfile.js Outdated
@@ -86,6 +87,15 @@ gulp.task('build-css', css.bind(null, false));
gulp.task('optimize-css', css.bind(null, true));
gulp.task('jscs', function() {
gutil.log("JSCS the files...." + '\n');
var lintFilter = filter(["**", "!config.js", "!map/us-counties.js", "!map/us-states.js", "!map/countries.js"]);

This comment has been minimized.

@GordonSmith

GordonSmith Aug 10, 2015

Member

Move lintFilter out of task so it can be reused in lint and jscs

This comment has been minimized.

@anmoljagetia

anmoljagetia Aug 10, 2015

Contributor

I am assuming there will be different files in them at a later point. (I am unsure of it, right now, so for now, should I move them out?)

This comment has been minimized.

@GordonSmith

GordonSmith Aug 10, 2015

Member

I am 99% sure that the same list will be used for both.

@GordonSmith

This comment has been minimized.

Member

GordonSmith commented Aug 10, 2015

jscs should also be called from "test"

@GordonSmith

This comment has been minimized.

Member

GordonSmith commented Aug 10, 2015

Can you roll up to one commit

@anmoljagetia anmoljagetia force-pushed the anmoljagetia:quoteRule branch from e784508 to f8377bb Aug 10, 2015

Adds code validation to the Framework
Signed-off-by: Anmol Jagetia <anmoljagetia@gmail.com>

@anmoljagetia anmoljagetia force-pushed the anmoljagetia:quoteRule branch from f8377bb to bfc5a4b Aug 10, 2015

GordonSmith added a commit that referenced this pull request Aug 11, 2015

Merge pull request #675 from anmoljagetia/quoteRule
Adds code validation to the Framework

@GordonSmith GordonSmith merged commit 83d13ae into hpcc-systems:master Aug 11, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment