Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
This comment has been minimized.
This comment has been minimized.
|
Can you roll up those commits. |
anmoljagetia
force-pushed the
anmoljagetia:fixQuote
branch
3 times, most recently
from
4b35fd0
to
806c5ab
Aug 10, 2015
This comment has been minimized.
This comment has been minimized.
|
Can you roll up those commits. |
anmoljagetia
force-pushed the
anmoljagetia:fixQuote
branch
from
dfed6f0
to
5700f34
Aug 11, 2015
This comment has been minimized.
This comment has been minimized.
|
Looks good. |
added a commit
that referenced
this pull request
Aug 11, 2015
GordonSmith
merged commit 1942472
into
hpcc-systems:master
Aug 11, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
anmoljagetia commentedAug 10, 2015
@GordonSmith Please Review
This is in continuation enforcing coding standards using JSCS. (Reference : PR #675). This fixes the single quote vs double quote style for the framework.