New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds lint for quote marks #677

Merged
merged 1 commit into from Aug 11, 2015

Conversation

Projects
None yet
2 participants
@anmoljagetia
Contributor

anmoljagetia commented Aug 10, 2015

@GordonSmith Please Review
This is in continuation enforcing coding standards using JSCS. (Reference : PR #675). This fixes the single quote vs double quote style for the framework.

@GordonSmith

This comment has been minimized.

Member

GordonSmith commented Aug 10, 2015

Can you roll up those commits.

@anmoljagetia anmoljagetia force-pushed the anmoljagetia:fixQuote branch 3 times, most recently from 4b35fd0 to 806c5ab Aug 10, 2015

@GordonSmith

This comment has been minimized.

Member

GordonSmith commented Aug 11, 2015

Can you roll up those commits.

Adds the fix for quotes
Signed-off-by: Anmol Jagetia <anmoljagetia@gmail.com>

@anmoljagetia anmoljagetia force-pushed the anmoljagetia:fixQuote branch from dfed6f0 to 5700f34 Aug 11, 2015

@GordonSmith

This comment has been minimized.

Member

GordonSmith commented Aug 11, 2015

Looks good.

GordonSmith added a commit that referenced this pull request Aug 11, 2015

Merge pull request #677 from anmoljagetia/fixQuote
Adds lint for quote marks

@GordonSmith GordonSmith merged commit 1942472 into hpcc-systems:master Aug 11, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment