New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML-278: Modified names to fix attribute name clashes #255

Merged
merged 1 commit into from Oct 17, 2016

Conversation

Projects
None yet
3 participants
@vivekaxl
Contributor

vivekaxl commented Sep 11, 2016

These changes were made so that the library can be run on legacy systems. I have tried compiling all the examples to make sure that it compiles.
Expect for two test cases in LSA (ML-311- which doesn't compile even without my changes) everything else works well.

@richardkchapman

This comment has been minimized.

Member

richardkchapman commented Sep 12, 2016

@johnholt Please review

@johnholt

Changes look correct. I need to run on the ML cluster under new and legacy import rules before I approve though. I am going to see if I can recruit some additional testers.

@johnholt

This comment has been minimized.

Collaborator

johnholt commented Oct 11, 2016

Have run a variety of attributes under legacy and the new import rules and get the same results. This pull request is good to be merged.

@richardkchapman richardkchapman merged commit 572e683 into hpcc-systems:master Oct 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment