Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE-803 Language colors don't seem to work 100% #448

Merged

Conversation

@dehilsterlexis
Copy link
Contributor

commented Oct 23, 2018

Fixed IDE-803

Signed-off-by: dehilsterlexis david.dehilster@lexisnexis.com

Fixed IDE-803

Signed-off-by: dehilsterlexis <david.dehilster@lexisnexis.com>
@dehilsterlexis

This comment has been minimized.

Copy link
Contributor Author

commented Oct 23, 2018

@GordonSmith this fixes one problem with the colorization. The only problem left is the single quote string colorization which appears to be a problem with scintilla, not our code. I will make a separate jira for that.

Copy link
Member

left a comment

Code looks fine.

@richardkchapman

This comment has been minimized.

Copy link
Member

commented Oct 29, 2018

Should this target 7.0.2?

@GordonSmith

This comment has been minimized.

Copy link
Member

commented Oct 30, 2018

@dehilsterlexis can you re-target PR?

@GordonSmith

This comment has been minimized.

Copy link
Member

commented Nov 30, 2018

@richardkchapman

This comment has been minimized.

Copy link
Member

commented Nov 30, 2018

At this point 7.0.4 or maybe 7.0.6 would be the target

@GordonSmith GordonSmith changed the base branch from master to candidate-7.0.4 Dec 5, 2018
@GordonSmith

This comment has been minimized.

Copy link
Member

commented Dec 5, 2018

@richardkchapman I re-targeted this change.

@richardkchapman richardkchapman merged commit 2cae68e into hpcc-systems:candidate-7.0.4 Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.