Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE-856 Combine ECL files to a MOD file using right click menu in the repository #465

Merged

Conversation

dehilsterlexis
Copy link
Contributor

… repository

Signed-off-by: dehilsterlexis david.dehilster@lexisnexis.com

@dehilsterlexis
Copy link
Contributor Author

@GordonSmith for review

Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - only minor change re indentation.

}
file.Close();
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Indentation looks wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix.

@dehilsterlexis
Copy link
Contributor Author

@GordonSmith for review

Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@richardkchapman
Copy link
Member

Should target 7.2.x

… repository

Signed-off-by: dehilsterlexis <david.dehilster@lexisnexis.com>
@dehilsterlexis dehilsterlexis changed the base branch from candidate-7.2.14 to candidate-7.2.x June 4, 2019 13:49
@dehilsterlexis
Copy link
Contributor Author

@richardkchapman rebased

@richardkchapman richardkchapman changed the title IDE-856 Combine ECL files to a MOD file using right click menu in the… IDE-856 Combine ECL files to a MOD file using right click menu in the repository Jun 5, 2019
@richardkchapman richardkchapman merged commit 5bcfc3e into hpcc-systems:candidate-7.2.x Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants