Add mkl 11.3.1.150 support #745
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
Jenkins: ok to test |
| @@ -357,7 +357,7 @@ def sanity_check_step(self): | |||
| if self.cfg['m32']: | |||
| raise EasyBuildError("Sanity check for 32-bit not implemented yet for IMKL v%s (>= 10.3)", self.version) | |||
| else: | |||
| mkldirs = ["bin", "mkl/bin", "mkl/bin/intel64", "mkl/lib/intel64", "mkl/include"] | |||
| mkldirs = ["bin", "mkl/bin", "mkl/lib/intel64", "mkl/include"] | |||
There was a problem hiding this comment.
we should only remove the check on mkl/bin/intel64 for the newest versions of imkl, and also check what kind of potential fallout this has (which tools are located in mkl/bin/intel, and where are they used by EB)?
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1372/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@jas02 please add yourself to the author list. I will pull in your commit. |
|
@wpoely86 Done, thanks. |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1423/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
will get merged via #756 |
|
Seems to be clean. |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1519/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Just to confirm: all these changes are already in develop, GitHub is not showing the correct diff for some reason... |
|
I just manually checked, that changes from #745 are already merged in |
Fixes the problem with wrong directory checking. There's no
mkl/bin/intel64anymore.