New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[dummy-dummy] cramtools 2.0 (Review) #1741
Conversation
Automatic reply from Jenkins: Can I test this? |
Test report by @npklein Ignore this, fails because I can't run test on the same cluster because of group right |
Jenkins: ok to test |
toolchain = {'name': 'dummy', 'version': 'dummy'} | ||
easyblock = 'Tarball' | ||
|
||
# download manually from http://www.broadinstitute.org/gatk/download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this?
Test report by @mmterpstra |
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3639/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3642/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Should I retest? It Should work & is now nicely formatted (i think). |
Test report by @mmterpstra |
|
||
sanity_check_paths = { | ||
'files': ["%(name)s-%(version)s.jar"], | ||
'dirs': ["lib"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please avoid using tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent with 4 spaces instead
@mmterpstra: just a couple more minor style remarks to look into, looks great otherwise |
- replaced tabs - removed hard coding in 'modloadmsg' - 'modloadmsg' now declared with single qoutes
Test report by @mmterpstra |
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Test report by @boegel |
Going in, thanks @mmterpstra! And welcome to the wonderful world of EasyBuild. :-) |
{bio}[dummy-dummy] cramtools 2.0 (Review)
No description provided.