Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[dummy-dummy] cramtools 2.0 (Review) #1741

Merged
merged 4 commits into from Jul 1, 2015

Conversation

mmterpstra
Copy link
Contributor

No description provided.

@hpcugentbot
Copy link
Contributor

Automatic reply from Jenkins: Can I test this?

@mmterpstra mmterpstra changed the title {bio}[dummy-dummy] cramtools 2.0 (Revie) {bio}[dummy-dummy] cramtools 2.0 (Review) Jun 24, 2015
@npklein
Copy link
Contributor

npklein commented Jun 24, 2015

Test report by @npklein
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz, Python 2.7.9
See https://gist.github.com/d1ef08abb17f963f2e34 for a full test report.


Ignore this, fails because I can't run test on the same cluster because of group right

@boegel
Copy link
Member

boegel commented Jun 24, 2015

Jenkins: ok to test

toolchain = {'name': 'dummy', 'version': 'dummy'}
easyblock = 'Tarball'

# download manually from http://www.broadinstitute.org/gatk/download
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this?

@mmterpstra
Copy link
Contributor Author

Test report by @mmterpstra
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz, Python 2.7.9
See https://gist.github.com/91530db0522f374159ac for a full test report.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3639/
Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3639/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3642/
Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3642/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3643/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3643/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@mmterpstra
Copy link
Contributor Author

Should I retest? It Should work & is now nicely formatted (i think).
Ps. 'bedankt' for commenting on branch and taking effort to add this.

@mmterpstra
Copy link
Contributor Author

Test report by @mmterpstra
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz, Python 2.7.9
See https://gist.github.com/ab8b122d398239d6aa15 for a full test report.


sanity_check_paths = {
'files': ["%(name)s-%(version)s.jar"],
'dirs': ["lib"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid using tabs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent with 4 spaces instead

@boegel
Copy link
Member

boegel commented Jul 1, 2015

@mmterpstra: just a couple more minor style remarks to look into, looks great otherwise

@boegel boegel added this to the v2.2 milestone Jul 1, 2015
- replaced tabs
- removed hard coding in  'modloadmsg'
- 'modloadmsg' now declared with single qoutes
@mmterpstra
Copy link
Contributor Author

Test report by @mmterpstra
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2660 0 @ 2.20GHz, Python 2.7.9
See https://gist.github.com/4271cd07066108efc79c for a full test report.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3685/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3685/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Jul 1, 2015

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/61eeee729b3619baff66 for a full test report.

@boegel
Copy link
Member

boegel commented Jul 1, 2015

Going in, thanks @mmterpstra!

And welcome to the wonderful world of EasyBuild. :-)

boegel added a commit that referenced this pull request Jul 1, 2015
{bio}[dummy-dummy] cramtools 2.0 (Review)
@boegel boegel merged commit 826d33d into easybuilders:develop Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants