Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create x265-1.9-goolf-1.7.20.eb #3090

Merged
merged 4 commits into from Nov 15, 2016
Merged

Conversation

eediaz1987
Copy link
Contributor

for goolf

@eediaz1987 eediaz1987 closed this May 20, 2016
@eediaz1987 eediaz1987 reopened this May 20, 2016
@boegel
Copy link
Member

boegel commented May 21, 2016

@eediaz1987 pull requests should be opened to the develop branch rather than master...

In addition, please move this easyconfig file down into a directory named x265 (see Travis tests failing).

@eediaz1987
Copy link
Contributor Author

i can't create the directory.

2016-05-21 7:28 GMT-04:00 Kenneth Hoste notifications@github.com:

@eediaz1987 https://github.com/eediaz1987 pull requests should be
opened to the develop branch rather than master...

In addition, please move this easyconfig file down into a directory named
x265 (see Travis tests failing).


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#3090 (comment)

@boegel
Copy link
Member

boegel commented May 23, 2016

@eediaz1987 I fixed this for you in eediaz1987#1, please merge that PR to update your branch

Note that you'll still need to reopen this PR to target the develop branch.

For future PRs, you should consider avoiding to use the GitHub web interface, it's not flexible enough...

@eediaz1987 eediaz1987 changed the base branch from master to develop November 14, 2016 15:24
@eediaz1987 eediaz1987 closed this Nov 14, 2016
@eediaz1987 eediaz1987 reopened this Nov 14, 2016
@boegel boegel added this to the 3.0 milestone Nov 14, 2016
@boegel boegel closed this Nov 14, 2016
@boegel boegel reopened this Nov 14, 2016
@boegel
Copy link
Member

boegel commented Nov 14, 2016

@eediaz1987 the tests are failing because this easyconfig file should be located in the easybuild/easyconfigs/x/x265/ directory (not in ``easybuild/easyconfigs/x/`)

@boegel boegel modified the milestones: 3.0, v3.x Nov 14, 2016
@eediaz1987
Copy link
Contributor Author

i try to create the directory x265 but in github i do not see how do that

2016-11-14 17:50 GMT+01:00 Kenneth Hoste notifications@github.com:

@eediaz1987 https://github.com/eediaz1987 the tests are failing because
this easyconfig file should be located in the
easybuild/easyconfigs/x/x265/ directory (not in `easybuild/easyconfigs/x/)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3090 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQVYWwtYT_rz69nsDPPrx7xQpqeWNlmCks5q-JFpgaJpZM4IjY8j
.

@boegel
Copy link
Member

boegel commented Nov 14, 2016

@eediaz1987 if you merge this pull request in your repository: eediaz1987#1

this PR will be updated, and the problems should be fixed

@boegel boegel modified the milestones: 3.0, v3.x Nov 14, 2016
fix location of x265 easyconfig + minor style fixes
source_urls = ['http://ftp.videolan.org/pub/videolan/x265/']
sources = ['x265_%(version)s.tar.gz']

builddependencies = [('CMake', '2.8.11')]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eediaz1987 you will need to bump this version to 3.5.2, since we only have an easyconfig available for that version of CMake with goolf.1.7.20

@boegel
Copy link
Member

boegel commented Nov 14, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2121.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/07b05c10a2e097a72ad5d2fb9fb8bc4e for a full test report.

@boegel
Copy link
Member

boegel commented Nov 14, 2016

lgtm

@boegel
Copy link
Member

boegel commented Nov 14, 2016

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in this PR)
node2637.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/408902adee3244df83e4ee57b14cdb2f for a full test report.

@eediaz1987 eediaz1987 closed this Nov 15, 2016
@eediaz1987 eediaz1987 reopened this Nov 15, 2016
@boegel
Copy link
Member

boegel commented Nov 15, 2016

@eediaz1987 Travis has some backlog, but everything should be fine, I'll merge this tomorrow morning.

@boegel
Copy link
Member

boegel commented Nov 15, 2016

Going in, thanks @eediaz1987!

@boegel boegel merged commit 23b5de9 into easybuilders:develop Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants