enhance --search: only consider actual filename (not entire path), use regex syntax #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (dirpath, dirnames, filenames) in os.walk(path, topdown=True): | ||
| for filename in filenames: | ||
| filename = os.path.join(dirpath, filename) | ||
| if filename.lower().find(query) != -1: | ||
| if query.search(filename.lower()): |
There was a problem hiding this comment.
add re.IGNORECASE to the regex?
There was a problem hiding this comment.
good point, totally forgot about this option 👍
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Going in, thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
May 13, 2015
enhance --search: only consider actual filename (not entire path), use regex syntax
|
@martbhell: this resolves the problem you ran into during the EasyBuild hackathon @ CSC.fi |
boegel
added a commit
to boegel/easybuild-framework
that referenced
this pull request
May 13, 2015
enhance --search: only consider actual filename (not entire path), use regex syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is motivated by the output of
--searchthat was produced byeb --search python, which in practice resulted in all easyconfigs to be listed (since it's not unlikely that 'python' is part of the full path).With this change, this works as expected: