From f05373ebdc97ba3d9c11059758166fd82bb9d9c8 Mon Sep 17 00:00:00 2001 From: Hunter Perrin Date: Fri, 10 Sep 2021 09:47:35 -0700 Subject: [PATCH] feat: migrate floating label, line ripple, and notched outline to typescript --- packages/banner/ambient.d.ts | 4 +- packages/chips/ambient.d.ts | 4 +- packages/data-table/Body.svelte | 4 +- packages/data-table/Row.svelte | 4 +- packages/floating-label/FloatingLabel.svelte | 56 +- .../floating-label/FloatingLabel.types.ts | 5 + packages/floating-label/bare.js | 2 - packages/floating-label/bare.ts | 2 + .../floating-label/{index.js => index.ts} | 1 + packages/floating-label/package-lock.json | 503 +--------------- packages/floating-label/package.json | 7 +- packages/floating-label/styled.js | 3 - packages/floating-label/styled.ts | 3 + packages/floating-label/tsconfig.json | 10 + packages/form-field/ambient.d.ts | 4 +- packages/icon-button/IconButton.svelte | 2 +- packages/line-ripple/LineRipple.svelte | 23 +- packages/line-ripple/bare.js | 2 - packages/line-ripple/bare.ts | 2 + packages/line-ripple/{index.js => index.ts} | 0 packages/line-ripple/package-lock.json | 441 +------------- packages/line-ripple/package.json | 7 +- packages/line-ripple/styled.js | 3 - packages/line-ripple/styled.ts | 3 + packages/line-ripple/tsconfig.json | 10 + packages/menu-surface/MenuSurface.svelte | 2 +- packages/menu/Menu.svelte | 2 +- .../notched-outline/NotchedOutline.svelte | 34 +- packages/notched-outline/ambient.d.ts | 10 + packages/notched-outline/bare.js | 2 - packages/notched-outline/bare.ts | 2 + .../notched-outline/{index.js => index.ts} | 0 packages/notched-outline/package-lock.json | 553 +----------------- packages/notched-outline/package.json | 10 +- packages/notched-outline/styled.js | 3 - packages/notched-outline/styled.ts | 3 + packages/notched-outline/tsconfig.json | 10 + packages/segmented-button/Segment.svelte | 4 +- .../segmented-button/SegmentedButton.svelte | 5 +- packages/top-app-bar/TopAppBar.svelte | 2 +- 40 files changed, 190 insertions(+), 1557 deletions(-) create mode 100644 packages/floating-label/FloatingLabel.types.ts delete mode 100644 packages/floating-label/bare.js create mode 100644 packages/floating-label/bare.ts rename packages/floating-label/{index.js => index.ts} (68%) delete mode 100644 packages/floating-label/styled.js create mode 100644 packages/floating-label/styled.ts create mode 100644 packages/floating-label/tsconfig.json delete mode 100644 packages/line-ripple/bare.js create mode 100644 packages/line-ripple/bare.ts rename packages/line-ripple/{index.js => index.ts} (100%) delete mode 100644 packages/line-ripple/styled.js create mode 100644 packages/line-ripple/styled.ts create mode 100644 packages/line-ripple/tsconfig.json create mode 100644 packages/notched-outline/ambient.d.ts delete mode 100644 packages/notched-outline/bare.js create mode 100644 packages/notched-outline/bare.ts rename packages/notched-outline/{index.js => index.ts} (100%) delete mode 100644 packages/notched-outline/styled.js create mode 100644 packages/notched-outline/styled.ts create mode 100644 packages/notched-outline/tsconfig.json diff --git a/packages/banner/ambient.d.ts b/packages/banner/ambient.d.ts index 0ed591db6..242f144ff 100644 --- a/packages/banner/ambient.d.ts +++ b/packages/banner/ambient.d.ts @@ -3,6 +3,8 @@ declare namespace svelte.JSX { ['onSMUIBannerButton:primaryActionClick']?: ( event: CustomEvent & { target: T } ) => any; - ['onSMUIBannerButton:secondaryActionClick']?: any; + ['onSMUIBannerButton:secondaryActionClick']?: ( + event: CustomEvent & { target: T } + ) => any; } } diff --git a/packages/chips/ambient.d.ts b/packages/chips/ambient.d.ts index 9bf758660..fbbf0d639 100644 --- a/packages/chips/ambient.d.ts +++ b/packages/chips/ambient.d.ts @@ -3,7 +3,9 @@ declare namespace svelte.JSX { ['onSMUIChipsChip:mount']?: ( event: CustomEvent & { target: T } ) => any; - ['onSMUIChipsChip:unmount']?: any; + ['onSMUIChipsChip:unmount']?: ( + event: CustomEvent & { target: T } + ) => any; ['onMDCChip:interaction']?: ( event: CustomEvent & { target: T } ) => any; diff --git a/packages/data-table/Body.svelte b/packages/data-table/Body.svelte index 0573127cf..55b668087 100644 --- a/packages/data-table/Body.svelte +++ b/packages/data-table/Body.svelte @@ -6,8 +6,8 @@ [className]: true, 'mdc-data-table__content': true, })} - on:SMUI:data-table:row:mount={handleRowMount} - on:SMUI:data-table:row:unmount={handleRowUnmount} + on:SMUIDataTableRow:mount={handleRowMount} + on:SMUIDataTableRow:unmount={handleRowUnmount} {...$$restProps}> diff --git a/packages/data-table/Row.svelte b/packages/data-table/Row.svelte index 523e62b7d..2cab5dd83 100644 --- a/packages/data-table/Row.svelte +++ b/packages/data-table/Row.svelte @@ -65,10 +65,10 @@ addAttr, }; - dispatch(getElement(), 'SMUI:data-table:row:mount', accessor); + dispatch(getElement(), 'SMUIDataTableRow:mount', accessor); return () => { - dispatch(getElement(), 'SMUI:data-table:row:unmount'); + dispatch(getElement(), 'SMUIDataTableRow:unmount'); }; }); diff --git a/packages/floating-label/FloatingLabel.svelte b/packages/floating-label/FloatingLabel.svelte index c78688d7c..12d44a936 100644 --- a/packages/floating-label/FloatingLabel.svelte +++ b/packages/floating-label/FloatingLabel.svelte @@ -32,12 +32,12 @@ .map(([name, value]) => `${name}: ${value};`) .concat([style]) .join(' ')} - for={forId || (inputProps ? inputProps.id : null)} + for={forId || (inputProps ? inputProps.id : undefined)} {...$$restProps}> {/if} -