From c36ef43515c633aa7e6e6dec326759e64561b02e Mon Sep 17 00:00:00 2001 From: kolioOtSofia Date: Wed, 7 Jul 2021 20:40:22 +0200 Subject: [PATCH 1/4] Updating the baseline --- .../BaselineOfAutoTDD.class/instance/baseline..st | 4 +++- .../BaselineOfAutoTDD.class/methodProperties.json | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/BaselineOfAutoTDD.package/BaselineOfAutoTDD.class/instance/baseline..st b/packages/BaselineOfAutoTDD.package/BaselineOfAutoTDD.class/instance/baseline..st index a1575c15..dbadeace 100644 --- a/packages/BaselineOfAutoTDD.package/BaselineOfAutoTDD.class/instance/baseline..st +++ b/packages/BaselineOfAutoTDD.package/BaselineOfAutoTDD.class/instance/baseline..st @@ -16,7 +16,8 @@ baseline: spec with: [ spec requires: #( 'libraries' - 'AutoTDD-Exceptions' ) ]; + 'AutoTDD-Exceptions' + 'AutoTDD-Help' ) ]; package: 'AutoTDD-GUI' with: [ spec requires: #( 'AutoTDD-Core' ) ]; postLoadDoIt: #postLoad; @@ -24,6 +25,7 @@ baseline: spec package: 'AutoTDD-Dummy-Failure-Tests'; package: 'AutoTDD-Dummy-Error-Tests'; package: 'AutoTDD-Dummy-Category'; + package: 'AutoTDD-Help'; package: 'AutoTDD-Exceptions'; package: 'AutoTDD-Dummy-Setting-Tests'; package: 'AutoTDD-Tests' diff --git a/packages/BaselineOfAutoTDD.package/BaselineOfAutoTDD.class/methodProperties.json b/packages/BaselineOfAutoTDD.package/BaselineOfAutoTDD.class/methodProperties.json index c38a0761..b8c29adc 100644 --- a/packages/BaselineOfAutoTDD.package/BaselineOfAutoTDD.class/methodProperties.json +++ b/packages/BaselineOfAutoTDD.package/BaselineOfAutoTDD.class/methodProperties.json @@ -2,5 +2,5 @@ "class" : { "createSar" : "ng 6/8/2021 11:50" }, "instance" : { - "baseline:" : "ct 10/7/2020 01:03", + "baseline:" : "ng 7/7/2021 20:37", "postLoad" : "be 5/29/2019 23:24" } } From 20a66d75532034d0812dd639667a55165cc83a5b Mon Sep 17 00:00:00 2001 From: kolioOtSofia Date: Fri, 9 Jul 2021 18:46:02 +0200 Subject: [PATCH 2/4] Improve exception handling, exceptions and increase robustness of application --- .../instance/requestOn..st | 8 ++++---- .../methodProperties.json | 2 +- .../class/{message.st => defaultMessage.st} | 2 +- .../instance/defaultAction.st | 4 ---- .../methodProperties.json | 5 ++--- .../ATDDAccessDeniedError.class/properties.json | 2 +- .../class/defaultMessage.st | 4 ++++ .../instance/defaultAction.st | 5 ----- .../methodProperties.json | 4 ++-- .../ATDDConnectionError.class/properties.json | 2 +- .../ATDDError.class/README.md | 1 + .../ATDDError.class/class/defaultMessage.st | 4 ++++ .../ATDDError.class/class/signal.st | 4 ++++ .../ATDDError.class/instance/defaultAction.st | 4 ++++ .../ATDDError.class/methodProperties.json | 6 ++++++ .../ATDDError.class/properties.json | 14 ++++++++++++++ .../{noValidSlugMessage.st => defaultMessage.st} | 2 +- .../instance/defaultAction.st | 4 ---- .../methodProperties.json | 4 ++-- .../ATDDNoValidSlugError.class/properties.json | 2 +- .../class/defaultMessage.st | 4 ++++ .../ATDDNotFoundError.class/class/message.st | 4 ---- .../instance/defaultAction.st | 4 ---- .../methodProperties.json | 4 ++-- .../ATDDNotFoundError.class/properties.json | 2 +- .../ATDDRateLimitError.class/README.md | 1 + .../class/defaultMessage.st} | 2 +- .../methodProperties.json | 5 +++++ .../ATDDRateLimitError.class/properties.json | 14 ++++++++++++++ .../instance/refreshGitHubAction..st | 2 +- .../instance/resumeGitHubAction..st | 2 +- .../ATDDBrowser.class/methodProperties.json | 4 ++-- .../instance/hasValidUrl.st | 15 --------------- .../instance/makesValidRequest.st | 11 +++++++++++ .../instance/save.st | 16 ++++++++++++---- .../methodProperties.json | 4 ++-- .../instance/updateJobLogForId..st | 4 ++-- .../methodProperties.json | 2 +- 38 files changed, 113 insertions(+), 70 deletions(-) rename packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/{message.st => defaultMessage.st} (65%) delete mode 100644 packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/instance/defaultAction.st create mode 100644 packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/class/defaultMessage.st delete mode 100644 packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/instance/defaultAction.st create mode 100644 packages/AutoTDD-Exceptions.package/ATDDError.class/README.md create mode 100644 packages/AutoTDD-Exceptions.package/ATDDError.class/class/defaultMessage.st create mode 100644 packages/AutoTDD-Exceptions.package/ATDDError.class/class/signal.st create mode 100644 packages/AutoTDD-Exceptions.package/ATDDError.class/instance/defaultAction.st create mode 100644 packages/AutoTDD-Exceptions.package/ATDDError.class/methodProperties.json create mode 100644 packages/AutoTDD-Exceptions.package/ATDDError.class/properties.json rename packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/class/{noValidSlugMessage.st => defaultMessage.st} (67%) delete mode 100644 packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/instance/defaultAction.st create mode 100644 packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/defaultMessage.st delete mode 100644 packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/message.st delete mode 100644 packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/instance/defaultAction.st create mode 100644 packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/README.md rename packages/AutoTDD-Exceptions.package/{ATDDAccessDeniedError.class/class/rateLimitMessage.st => ATDDRateLimitError.class/class/defaultMessage.st} (88%) create mode 100644 packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/methodProperties.json create mode 100644 packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/properties.json delete mode 100644 packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st create mode 100644 packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/makesValidRequest.st diff --git a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/requestOn..st b/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/requestOn..st index 5218982d..8a440243 100644 --- a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/requestOn..st +++ b/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/requestOn..st @@ -13,9 +13,9 @@ requestOn: aString on: Error do: [ :error | [ ATDDConnectionError signal: 'Connection failed: ' , error messageText ] fork. - ^ JsonObject new ]. - ^ response code - = 200 + ^ nil ]. + + response code = 200 ifTrue: [ (response contentType includesSubstring: 'application/json') ifTrue: [ ^ Json readFrom: response content readStream ]. @@ -24,4 +24,4 @@ requestOn: aString ] ifFalse: [ self throwExceptionForResponseCode: response code. - JsonObject new ] \ No newline at end of file + ^ nil ] \ No newline at end of file diff --git a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/methodProperties.json index ba2fe383..c9a3f5b0 100644 --- a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/methodProperties.json +++ b/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/methodProperties.json @@ -9,4 +9,4 @@ "getJsonForWorkflowRunsForRepository:" : "ng 5/22/2021 19:16", "getLogsForRepository:logId:" : "BF 6/25/2021 17:13", "mimeType" : "ng 5/14/2021 15:45", - "requestOn:" : "BF 6/26/2021 14:46" } } + "requestOn:" : "ng 7/9/2021 18:07" } } diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/message.st b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/defaultMessage.st similarity index 65% rename from packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/message.st rename to packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/defaultMessage.st index fb1c10b7..d930956f 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/message.st +++ b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/defaultMessage.st @@ -1,4 +1,4 @@ accessing -message +defaultMessage ^ 'Access denied' \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/instance/defaultAction.st deleted file mode 100644 index 11f69e80..00000000 --- a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/instance/defaultAction.st +++ /dev/null @@ -1,4 +0,0 @@ -priv handling -defaultAction - - ^ Transcript show: self class message \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json index e4753196..ee7849ac 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json @@ -1,6 +1,5 @@ { "class" : { - "message" : "ng 6/18/2021 13:55", - "rateLimitMessage" : "BF 6/18/2021 14:51" }, + "defaultMessage" : "ng 7/9/2021 18:25" }, "instance" : { - "defaultAction" : "ng 6/18/2021 13:53" } } + } } diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/properties.json b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/properties.json index 8ef90454..13051c2d 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/properties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/properties.json @@ -10,5 +10,5 @@ "name" : "ATDDAccessDeniedError", "pools" : [ ], - "super" : "Error", + "super" : "ATDDError", "type" : "normal" } diff --git a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/class/defaultMessage.st b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/class/defaultMessage.st new file mode 100644 index 00000000..5cb0f662 --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/class/defaultMessage.st @@ -0,0 +1,4 @@ +accessing +defaultMessage + + ^ 'Not a valid token.' \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/instance/defaultAction.st deleted file mode 100644 index 130a20a8..00000000 --- a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/instance/defaultAction.st +++ /dev/null @@ -1,5 +0,0 @@ -priv handling -defaultAction - "UIManager default inform: self messageText" - - ^ Transcript show: self messageText \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/methodProperties.json index fe2abe06..31587213 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/methodProperties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/methodProperties.json @@ -1,5 +1,5 @@ { "class" : { - }, + "defaultMessage" : "ng 7/9/2021 18:27" }, "instance" : { - "defaultAction" : "ng 6/18/2021 14:03" } } + } } diff --git a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/properties.json b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/properties.json index 6ef81be3..d2a92685 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/properties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/properties.json @@ -10,5 +10,5 @@ "name" : "ATDDConnectionError", "pools" : [ ], - "super" : "Error", + "super" : "ATDDError", "type" : "normal" } diff --git a/packages/AutoTDD-Exceptions.package/ATDDError.class/README.md b/packages/AutoTDD-Exceptions.package/ATDDError.class/README.md new file mode 100644 index 00000000..8a75b168 --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDError.class/README.md @@ -0,0 +1 @@ +An ATDDError is an abstraction of any Error in AutoTDD. \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDError.class/class/defaultMessage.st b/packages/AutoTDD-Exceptions.package/ATDDError.class/class/defaultMessage.st new file mode 100644 index 00000000..6b6f7f5d --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDError.class/class/defaultMessage.st @@ -0,0 +1,4 @@ +accessing +defaultMessage + + ^ self subclassResponsibility \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDError.class/class/signal.st b/packages/AutoTDD-Exceptions.package/ATDDError.class/class/signal.st new file mode 100644 index 00000000..795ffa9a --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDError.class/class/signal.st @@ -0,0 +1,4 @@ +accessing +signal + + ^ Error signal: 'This class is abstract, please do not signal to it.' \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/ATDDError.class/instance/defaultAction.st new file mode 100644 index 00000000..9f82bede --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDError.class/instance/defaultAction.st @@ -0,0 +1,4 @@ +priv handling +defaultAction + + ^ Transcript show: self class defaultMessage \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDError.class/methodProperties.json new file mode 100644 index 00000000..e79c64fc --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDError.class/methodProperties.json @@ -0,0 +1,6 @@ +{ + "class" : { + "defaultMessage" : "ng 7/9/2021 18:25", + "signal" : "ng 7/9/2021 18:42" }, + "instance" : { + "defaultAction" : "ng 7/9/2021 18:31" } } diff --git a/packages/AutoTDD-Exceptions.package/ATDDError.class/properties.json b/packages/AutoTDD-Exceptions.package/ATDDError.class/properties.json new file mode 100644 index 00000000..9c205d76 --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDError.class/properties.json @@ -0,0 +1,14 @@ +{ + "category" : "AutoTDD-Exceptions", + "classinstvars" : [ + ], + "classvars" : [ + ], + "commentStamp" : "ng 7/9/2021 18:32", + "instvars" : [ + ], + "name" : "ATDDError", + "pools" : [ + ], + "super" : "Error", + "type" : "normal" } diff --git a/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/class/noValidSlugMessage.st b/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/class/defaultMessage.st similarity index 67% rename from packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/class/noValidSlugMessage.st rename to packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/class/defaultMessage.st index 5fbe4b75..55294ea1 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/class/noValidSlugMessage.st +++ b/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/class/defaultMessage.st @@ -1,4 +1,4 @@ accessing -noValidSlugMessage +defaultMessage ^ 'No valid slug provided' \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/instance/defaultAction.st deleted file mode 100644 index 46a9eca5..00000000 --- a/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/instance/defaultAction.st +++ /dev/null @@ -1,4 +0,0 @@ -priv handling -defaultAction - - ^ UIManager default inform: self class noValidSlugMessage \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/methodProperties.json index 84b3dd1c..bfcb07bd 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/methodProperties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/methodProperties.json @@ -1,5 +1,5 @@ { "class" : { - "noValidSlugMessage" : "swi 7/25/2019 14:19" }, + "defaultMessage" : "ng 7/9/2021 18:28" }, "instance" : { - "defaultAction" : "swi 7/25/2019 14:19" } } + } } diff --git a/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/properties.json b/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/properties.json index 823c9623..b12fb821 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/properties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/properties.json @@ -10,5 +10,5 @@ "name" : "ATDDNoValidSlugError", "pools" : [ ], - "super" : "Error", + "super" : "ATDDError", "type" : "normal" } diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/defaultMessage.st b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/defaultMessage.st new file mode 100644 index 00000000..64b258ff --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/defaultMessage.st @@ -0,0 +1,4 @@ +accessing +defaultMessage + + ^ 'Error 404! Please provide a valid {owner}/{repo}' \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/message.st b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/message.st deleted file mode 100644 index 22e2867a..00000000 --- a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/message.st +++ /dev/null @@ -1,4 +0,0 @@ -accessing -message - - ^ 'Not Found' \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/instance/defaultAction.st deleted file mode 100644 index 11f69e80..00000000 --- a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/instance/defaultAction.st +++ /dev/null @@ -1,4 +0,0 @@ -priv handling -defaultAction - - ^ Transcript show: self class message \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/methodProperties.json index ccc57556..154bd59f 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/methodProperties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/methodProperties.json @@ -1,5 +1,5 @@ { "class" : { - "message" : "ng 6/18/2021 13:55" }, + "defaultMessage" : "ng 7/9/2021 18:37" }, "instance" : { - "defaultAction" : "ng 6/18/2021 13:59" } } + } } diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/properties.json b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/properties.json index 7b31a132..6a8c06f5 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/properties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/properties.json @@ -10,5 +10,5 @@ "name" : "ATDDNotFoundError", "pools" : [ ], - "super" : "Error", + "super" : "ATDDError", "type" : "normal" } diff --git a/packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/README.md b/packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/README.md new file mode 100644 index 00000000..31facf07 --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/README.md @@ -0,0 +1 @@ +An ATDDRateLimitError is an ATDDAccessDeniedError that was thrown because the API's rate limit was exceeded. \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/rateLimitMessage.st b/packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/class/defaultMessage.st similarity index 88% rename from packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/rateLimitMessage.st rename to packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/class/defaultMessage.st index 05b867e8..6556fbe7 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/rateLimitMessage.st +++ b/packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/class/defaultMessage.st @@ -1,4 +1,4 @@ accessing -rateLimitMessage +defaultMessage ^ 'You have been rate-limited. This GitHub Action will now be paused. Consider providing a token to prevent this.' \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/methodProperties.json new file mode 100644 index 00000000..032e517b --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/methodProperties.json @@ -0,0 +1,5 @@ +{ + "class" : { + "defaultMessage" : "ng 7/9/2021 18:35" }, + "instance" : { + } } diff --git a/packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/properties.json b/packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/properties.json new file mode 100644 index 00000000..38868739 --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDRateLimitError.class/properties.json @@ -0,0 +1,14 @@ +{ + "category" : "AutoTDD-Exceptions", + "classinstvars" : [ + ], + "classvars" : [ + ], + "commentStamp" : "ng 7/9/2021 18:34", + "instvars" : [ + ], + "name" : "ATDDRateLimitError", + "pools" : [ + ], + "super" : "ATDDAccessDeniedError", + "type" : "normal" } diff --git a/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/refreshGitHubAction..st b/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/refreshGitHubAction..st index 313bbe06..612f94f0 100644 --- a/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/refreshGitHubAction..st +++ b/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/refreshGitHubAction..st @@ -4,6 +4,6 @@ refreshGitHubAction: aGitHubAction [ aGitHubAction refresh ] on: ATDDAccessDeniedError do: [ - UIManager default inform: ATDDAccessDeniedError rateLimitMessage. + UIManager default inform: ATDDRateLimitError defaultMessage. self pauseTestingEntity: aGitHubAction ] \ No newline at end of file diff --git a/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st b/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st index 054931d9..dbc4176b 100644 --- a/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st +++ b/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st @@ -4,6 +4,6 @@ resumeGitHubAction: aGitHubAction [ aGitHubAction resume ] on: ATDDAccessDeniedError do: [ - UIManager default inform: ATDDAccessDeniedError rateLimitMessage. + UIManager default inform: ATDDRateLimitError defaultMessage. self pauseTestingEntity: aGitHubAction ] \ No newline at end of file diff --git a/packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json b/packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json index 79991264..9c7cf78f 100644 --- a/packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json +++ b/packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json @@ -116,7 +116,7 @@ "pauseTestingEntity:" : "sw 5/28/2021 15:17", "pauseTravisStatuses" : "sw 5/26/2021 00:03", "pauseWatchers" : "sw 5/26/2021 00:04", - "refreshGitHubAction:" : "BF 6/18/2021 14:51", + "refreshGitHubAction:" : "ng 7/9/2021 18:36", "refreshTravisStatus:" : "swi 7/10/2019 14:03", "removeGitHubActions:" : "sw 5/25/2021 22:58", "removeSelectedGitHubActions" : "sw 5/24/2021 14:00", @@ -128,7 +128,7 @@ "resultsTravisStatuses" : "sw 5/26/2021 00:07", "resultsWatchers" : "sw 5/26/2021 00:07", "resumeAll" : "sw 5/21/2021 21:05", - "resumeGitHubAction:" : "BF 6/18/2021 14:51", + "resumeGitHubAction:" : "ng 7/9/2021 18:36", "resumeSelectedGitHubActions" : "sw 5/21/2021 22:17", "resumeSelectedTravisStatuses" : "swi 7/25/2019 15:30", "resumeSelectedWatchers" : "swi 7/25/2019 15:31", diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st deleted file mode 100644 index 75888ae5..00000000 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st +++ /dev/null @@ -1,15 +0,0 @@ -testing -hasValidUrl - - | client | - - client := ATDDGitHubActionsClient new. - client token: self token. - [ client requestOn: 'repos/' , self repositoryUrl ] - on: ATDDAccessDeniedError - do: [ UIManager default inform: ATDDAccessDeniedError rateLimitMessage. ] - on: ATDDNotFoundError - do: [ ^ false ]. - - ^ true - diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/makesValidRequest.st b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/makesValidRequest.st new file mode 100644 index 00000000..26a0117c --- /dev/null +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/makesValidRequest.st @@ -0,0 +1,11 @@ +testing +makesValidRequest + + | client | + + client := ATDDGitHubActionsClient new. + client token: self token. + (client requestOn: 'repos/' , self repositoryUrl) + ifNil: [ ^ false ]. + + ^ true \ No newline at end of file diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/save.st b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/save.st index 03b79a36..c2c0134e 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/save.st +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/save.st @@ -4,6 +4,7 @@ save repositoryUrl changed: #acceptChanges. token changed: #acceptChanges. refreshInterval changed: #acceptChanges. + self hasVaildRefreshInterval ifFalse: [ UIManager default inform: 'Please enter a valid interval!'. @@ -12,11 +13,18 @@ save ifFalse: [ UIManager default inform: 'Please enter a valid slug!'. ^ nil ]. - self hasValidUrl - ifFalse: [ - UIManager default inform: 'Error 404! Please provide a valid {owner}/{repo}'. + + [ self makesValidRequest ] + on: ATDDConnectionError + do: [ UIManager default inform: ATDDConnectionError defaultMessage. + ^ nil ] + on: ATDDAccessDeniedError + do: [ UIManager default inform: ATDDRateLimitError defaultMessage. + ^ nil ] + on: ATDDNotFoundError + do: [ UIManager default inform: ATDDNotFoundError defaultMessage. ^ nil ]. + super save. self closeWindow. - ^ self applyChanges \ No newline at end of file diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/methodProperties.json b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/methodProperties.json index aec04bc4..368e61d9 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/methodProperties.json +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/methodProperties.json @@ -11,5 +11,5 @@ "instance" : { "applyChanges" : "BF 6/18/2021 14:54", "gitHubAction" : "sw 5/25/2021 19:21", - "hasValidUrl" : "BF 6/18/2021 14:52", - "save" : "ng 6/18/2021 14:53" } } + "makesValidRequest" : "ng 7/9/2021 18:14", + "save" : "ng 7/9/2021 18:37" } } diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobLogForId..st b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobLogForId..st index 98161757..4c9027f7 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobLogForId..st +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobLogForId..st @@ -5,9 +5,9 @@ updateJobLogForId: aNumber [ response := self data client getLogsForRepository: self data repository logId: aNumber ] on: ATDDAccessDeniedError - do: [ :error | response := error class message , '. Logs are only available when providing a token.' ] + do: [ :error | response := error class defaultMessage , '. Logs are only available when providing a token.' ] on: ATDDNotFoundError - do: [ :error | response := error class message , '. No logs available for this workflow.' ]. + do: [ :error | response := error class defaultMessage , '. No logs available for this workflow.' ]. (self shouldSimplifyLog) ifTrue: [ diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json index afef8129..06322a5e 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json @@ -25,5 +25,5 @@ "simplifyLogCheckBoxFrame" : "BF 6/20/2021 16:35", "simplifyLogCheckBoxLabel" : "BF 6/20/2021 16:35", "simplifyLogCheckBoxState" : "BF 6/20/2021 16:36", - "updateJobLogForId:" : "BF 6/20/2021 16:36", + "updateJobLogForId:" : "ng 7/9/2021 18:26", "updateJobs" : "BF 6/25/2021 17:13" } } From d24abff3bebc0ab115066ee1e5d7de1d4079bde0 Mon Sep 17 00:00:00 2001 From: kolioOtSofia Date: Fri, 9 Jul 2021 18:49:16 +0200 Subject: [PATCH 3/4] bugfix: errors could not be signale anymore --- .../ATDDError.class/class/signal.st | 4 ---- .../ATDDError.class/methodProperties.json | 3 +-- 2 files changed, 1 insertion(+), 6 deletions(-) delete mode 100644 packages/AutoTDD-Exceptions.package/ATDDError.class/class/signal.st diff --git a/packages/AutoTDD-Exceptions.package/ATDDError.class/class/signal.st b/packages/AutoTDD-Exceptions.package/ATDDError.class/class/signal.st deleted file mode 100644 index 795ffa9a..00000000 --- a/packages/AutoTDD-Exceptions.package/ATDDError.class/class/signal.st +++ /dev/null @@ -1,4 +0,0 @@ -accessing -signal - - ^ Error signal: 'This class is abstract, please do not signal to it.' \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDError.class/methodProperties.json index e79c64fc..649257b3 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDError.class/methodProperties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDError.class/methodProperties.json @@ -1,6 +1,5 @@ { "class" : { - "defaultMessage" : "ng 7/9/2021 18:25", - "signal" : "ng 7/9/2021 18:42" }, + "defaultMessage" : "ng 7/9/2021 18:25" }, "instance" : { "defaultAction" : "ng 7/9/2021 18:31" } } From 8fbb4a9a968bfac2ac46f4dc898721f817f30da7 Mon Sep 17 00:00:00 2001 From: kolioOtSofia Date: Sun, 11 Jul 2021 15:20:04 +0200 Subject: [PATCH 4/4] renaming class --- .../instance/validate..st | 2 +- .../methodProperties.json | 2 +- .../README.md | 0 .../class/defaultMessage.st | 0 .../methodProperties.json | 0 .../properties.json | 2 +- .../instance/testValidateSlug.st | 22 +++++++++---------- .../methodProperties.json | 2 +- 8 files changed, 15 insertions(+), 15 deletions(-) rename packages/AutoTDD-Exceptions.package/{ATDDNoValidSlugError.class => ATDDInvalidSlugError.class}/README.md (100%) rename packages/AutoTDD-Exceptions.package/{ATDDNoValidSlugError.class => ATDDInvalidSlugError.class}/class/defaultMessage.st (100%) rename packages/AutoTDD-Exceptions.package/{ATDDNoValidSlugError.class => ATDDInvalidSlugError.class}/methodProperties.json (100%) rename packages/AutoTDD-Exceptions.package/{ATDDNoValidSlugError.class => ATDDInvalidSlugError.class}/properties.json (86%) diff --git a/packages/AutoTDD-Core.package/ATDDRemoteRepository.class/instance/validate..st b/packages/AutoTDD-Core.package/ATDDRemoteRepository.class/instance/validate..st index fef9eb58..4d6424eb 100644 --- a/packages/AutoTDD-Core.package/ATDDRemoteRepository.class/instance/validate..st +++ b/packages/AutoTDD-Core.package/ATDDRemoteRepository.class/instance/validate..st @@ -1,4 +1,4 @@ action validate: aString - (aString matchesRegex: self class validSlug) ifFalse: [ ATDDNoValidSlugError signal ] \ No newline at end of file + (aString matchesRegex: self class validSlug) ifFalse: [ ATDDInvalidSlugError signal ] \ No newline at end of file diff --git a/packages/AutoTDD-Core.package/ATDDRemoteRepository.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDRemoteRepository.class/methodProperties.json index ccc9c0c9..de5d0c17 100644 --- a/packages/AutoTDD-Core.package/ATDDRemoteRepository.class/methodProperties.json +++ b/packages/AutoTDD-Core.package/ATDDRemoteRepository.class/methodProperties.json @@ -13,4 +13,4 @@ "token" : "ClassTest 6/25/2021 16:28", "token:" : "ClassTest 6/25/2021 16:28", "update" : "ClassTest 6/25/2021 16:27", - "validate:" : "ClassTest 6/25/2021 16:58" } } + "validate:" : "ng 7/11/2021 15:19" } } diff --git a/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/README.md b/packages/AutoTDD-Exceptions.package/ATDDInvalidSlugError.class/README.md similarity index 100% rename from packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/README.md rename to packages/AutoTDD-Exceptions.package/ATDDInvalidSlugError.class/README.md diff --git a/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/class/defaultMessage.st b/packages/AutoTDD-Exceptions.package/ATDDInvalidSlugError.class/class/defaultMessage.st similarity index 100% rename from packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/class/defaultMessage.st rename to packages/AutoTDD-Exceptions.package/ATDDInvalidSlugError.class/class/defaultMessage.st diff --git a/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDInvalidSlugError.class/methodProperties.json similarity index 100% rename from packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/methodProperties.json rename to packages/AutoTDD-Exceptions.package/ATDDInvalidSlugError.class/methodProperties.json diff --git a/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/properties.json b/packages/AutoTDD-Exceptions.package/ATDDInvalidSlugError.class/properties.json similarity index 86% rename from packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/properties.json rename to packages/AutoTDD-Exceptions.package/ATDDInvalidSlugError.class/properties.json index b12fb821..4cdbc3e6 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/properties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDInvalidSlugError.class/properties.json @@ -7,7 +7,7 @@ "commentStamp" : "be 7/25/2019 10:29", "instvars" : [ ], - "name" : "ATDDNoValidSlugError", + "name" : "ATDDInvalidSlugError", "pools" : [ ], "super" : "ATDDError", diff --git a/packages/AutoTDD-Tests.package/ATDDGitHubActionsRepositoryTest.class/instance/testValidateSlug.st b/packages/AutoTDD-Tests.package/ATDDGitHubActionsRepositoryTest.class/instance/testValidateSlug.st index d508d974..88111284 100644 --- a/packages/AutoTDD-Tests.package/ATDDGitHubActionsRepositoryTest.class/instance/testValidateSlug.st +++ b/packages/AutoTDD-Tests.package/ATDDGitHubActionsRepositoryTest.class/instance/testValidateSlug.st @@ -2,14 +2,14 @@ tests testValidateSlug self - shouldnt: [ repository repository: 'a/b' ] raise: ATDDNoValidSlugError; - shouldnt: [ repository repository: 'a0/-b' ] raise: ATDDNoValidSlugError; - should: [ repository repository: 'a/' ] raise: ATDDNoValidSlugError; - should: [ repository repository: '/b' ] raise: ATDDNoValidSlugError; - should: [ repository repository: '/' ] raise: ATDDNoValidSlugError; - should: [ repository repository: 'a /b' ] raise: ATDDNoValidSlugError; - should: [ repository repository: 'a/ b' ] raise: ATDDNoValidSlugError; - should: [ repository repository: ' a/b' ] raise: ATDDNoValidSlugError; - should: [ repository repository: 'a/b ' ] raise: ATDDNoValidSlugError; - should: [ repository repository: 'a/b/c' ] raise: ATDDNoValidSlugError; - should: [ repository repository: 'ab' ] raise: ATDDNoValidSlugError \ No newline at end of file + shouldnt: [ repository repository: 'a/b' ] raise: ATDDInvalidSlugError; + shouldnt: [ repository repository: 'a0/-b' ] raise: ATDDInvalidSlugError; + should: [ repository repository: 'a/' ] raise: ATDDInvalidSlugError; + should: [ repository repository: '/b' ] raise: ATDDInvalidSlugError; + should: [ repository repository: '/' ] raise: ATDDInvalidSlugError; + should: [ repository repository: 'a /b' ] raise: ATDDInvalidSlugError; + should: [ repository repository: 'a/ b' ] raise: ATDDInvalidSlugError; + should: [ repository repository: ' a/b' ] raise: ATDDInvalidSlugError; + should: [ repository repository: 'a/b ' ] raise: ATDDInvalidSlugError; + should: [ repository repository: 'a/b/c' ] raise: ATDDInvalidSlugError; + should: [ repository repository: 'ab' ] raise: ATDDInvalidSlugError \ No newline at end of file diff --git a/packages/AutoTDD-Tests.package/ATDDGitHubActionsRepositoryTest.class/methodProperties.json b/packages/AutoTDD-Tests.package/ATDDGitHubActionsRepositoryTest.class/methodProperties.json index a96d1b2e..a955cd61 100644 --- a/packages/AutoTDD-Tests.package/ATDDGitHubActionsRepositoryTest.class/methodProperties.json +++ b/packages/AutoTDD-Tests.package/ATDDGitHubActionsRepositoryTest.class/methodProperties.json @@ -6,4 +6,4 @@ "tearDown" : "ClassTest 7/3/2021 20:59", "testInitialization" : "ClassTest 7/3/2021 20:59", "testRequireRepository" : "ng 7/2/2021 18:47", - "testValidateSlug" : "ClassTest 6/25/2021 16:59" } } + "testValidateSlug" : "ng 7/11/2021 15:19" } }