Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geom_scdensity #46

Open
hrbrmstr opened this issue Jan 30, 2018 · 39 comments
Open

geom_scdensity #46

hrbrmstr opened this issue Jan 30, 2018 · 39 comments

Comments

@hrbrmstr
Copy link
Owner

@hrbrmstr hrbrmstr commented Jan 30, 2018

@xvrdm
Copy link

@xvrdm xvrdm commented Jan 30, 2018

Hi Bob, I would be very interested to see how a contribution is made!! Thanks a lot for offering.

@JoGall
Copy link

@JoGall JoGall commented Jan 30, 2018

I'd love to see behind the scenes of a ggplot2 geom / stat, thanks!

@dmi3kno
Copy link

@dmi3kno dmi3kno commented Jan 30, 2018

I am in as well

@kanishkamisra
Copy link

@kanishkamisra kanishkamisra commented Jan 30, 2018

Very much interested in knowing how to make a geom! Thanks a lot for this :)

@timtrice
Copy link

@timtrice timtrice commented Jan 30, 2018

Interested, as well.

@hrbrmstr
Copy link
Owner Author

@hrbrmstr hrbrmstr commented Jan 30, 2018

(just a quick note as I'm traveling a bit through Wed and internet is spotty for me)

Wow! You folks are amazing (not exaggerating).

I'd like to be able to accommodate everyone so lemme ponder a good format. Wld folks be up for both some static resources (e.g. vignette-ish tutorial) and a live (but also recorded) session or two (esp a Q&A session or two)?

@timtrice
Copy link

@timtrice timtrice commented Jan 30, 2018

Personally I'd prefer a vignette-type document but I'm also willing to transcribe a video if it's easier for the community.

@dmi3kno
Copy link

@dmi3kno dmi3kno commented Jan 30, 2018

I would also enjoy bite-size assignments: "take this code, modify function x to produce y". I would appreciate if you could outline your approach to starting new geom - what to do first, what to keep in mind, where should one start (I suspect there are many examples to copy). Very happy to do something on my own and have other people mock/comment on my code.

@xvrdm
Copy link

@xvrdm xvrdm commented Jan 30, 2018

Very interested in a video+vignette approach! 2 things I find particularly intriguing : how do you test geom before submitting a pull request and what does a properly formatted/documented pull request look like?

@LVG77
Copy link

@LVG77 LVG77 commented Jan 30, 2018

Hi Bob, thank you for your offer! I am very much interested in learning more about the creation of ggplot2 geoms and the overall process of submitting a PR.

@kanishkamisra
Copy link

@kanishkamisra kanishkamisra commented Jan 30, 2018

A vignette seems great to me, a live session would depend on timings but if I am free I will surely join!

@ghost
Copy link

@ghost ghost commented Jan 30, 2018

I'd like to sign in as well. I built a package for my company that "creates" a geom but is actually just a wrapper for geom_point, and it's very clunky. I'd love to have a better understanding on how to properly build a geom. A vignette would be great.

@MHenderson
Copy link

@MHenderson MHenderson commented Jan 30, 2018

I am also interested. Thanks.

@bhive01
Copy link

@bhive01 bhive01 commented Jan 30, 2018

I'd like to add to the pile. For as long as I've used ggplot2, I've rarely been able to understand its guts. This would be a good primer.

@malcolmbarrett
Copy link

@malcolmbarrett malcolmbarrett commented Jan 30, 2018

What a great introduction. I would love to be involved.

@sefabey
Copy link

@sefabey sefabey commented Jan 30, 2018

Interested, gotta shake up this imposter syndrome (though I know little).

@ateucher
Copy link

@ateucher ateucher commented Jan 30, 2018

What they said ⬆️

1 similar comment
@cimentadaj
Copy link

@cimentadaj cimentadaj commented Jan 30, 2018

What they said ⬆️

@ghost
Copy link

@ghost ghost commented Jan 30, 2018

Hi Bob, I am interested in seeing how a contribution is made!! Thank you for the offer.

@mvevans89
Copy link

@mvevans89 mvevans89 commented Jan 30, 2018

I'd definitely be interested. Seems like with this amount of interest, a vignette may be easiest but anything would be 💯

@hrbrmstr
Copy link
Owner Author

@hrbrmstr hrbrmstr commented Jan 30, 2018

Awesome folks.

Lemme try an incremental bookdown tutorial/splainer/vignette on this (chapter a topic). That way I can get something going right away and keep y'all interested & informed. And, there are a cpl more straightforward geoms that I can pull up that "need" implementing, so there's likely something for everyone, too.

@robertmitchellv
Copy link

@robertmitchellv robertmitchellv commented Jan 31, 2018

Just saw your tweet Bob; I’m very keen to dive deeper into geoms! If you can squeeze me in that is.

@smouksassi
Copy link

@smouksassi smouksassi commented Jan 31, 2018

looking forward to learn more and work on s stat quantile that can do ribbons using rqss

@jthomasmock
Copy link

@jthomasmock jthomasmock commented Jan 31, 2018

Looking to contribute!

@AndreaPi
Copy link

@AndreaPi AndreaPi commented Jan 31, 2018

I'm interested too! Video or vignette is the same, whatever works better for you. I would be happy to contribute, with my beginner-level skills (never loaded a package on CRAN before :-)

@daranzolin
Copy link

@daranzolin daranzolin commented Jan 31, 2018

Sign me up!

@sibusiso16
Copy link

@sibusiso16 sibusiso16 commented Jan 31, 2018

I’m also interested, thank you!

@afayyazuddin
Copy link

@afayyazuddin afayyazuddin commented Feb 1, 2018

Thank you for your offer! I am also interested.

@xdoan
Copy link

@xdoan xdoan commented Feb 1, 2018

This sounds great! I would also love to contribute. Thanks so much for this great opportunity.

@eringrand
Copy link

@eringrand eringrand commented Feb 2, 2018

I'm also interested!

@hrbrmstr
Copy link
Owner Author

@hrbrmstr hrbrmstr commented Feb 2, 2018

Alright (phew) I'm done traveling this week will get something going by tomorrow for this.

@hrbrmstr
Copy link
Owner Author

@hrbrmstr hrbrmstr commented Feb 3, 2018

And, the first part (which is more of a "please ensure you've done these things first") is up.

https://rud.is/books/creating-ggplot2-extensions/

I'll be linking to each new chapter as I get through them (one more coming today at a minimum) and the bookdown source will eventually be exposed on GitHub but I'm writing this for y'all vs all the gitstalkers so I'd rather you see the content first before anyone else notices. Feel free to drop "what the heck?!"'s or other q's here or DM me on Twitter if q's in an open forum isn't your cup of tea (ages ago I used to be more than a bit hesitant to ask q's in an open forum, therefore I grok how others might be uncomfortable doing so as well).

@hrbrmstr
Copy link
Owner Author

@hrbrmstr hrbrmstr commented Feb 3, 2018

And, as promised, here is the first "real" chapter: "Demystifying ggplot2" : https://rud.is/books/creating-ggplot2-extensions/demystifying-ggplot2.html

It covers the basic structure of a ggplot2 plot, how it goes from grammar of graphics to final visualized output and delves into the objects that are created along the way.

There are exercises at the end which will really help you later on down the road.

I'll give folks a cpl of days to work through it before posting another chapter.

@EmilHvitfeldt
Copy link

@EmilHvitfeldt EmilHvitfeldt commented Feb 3, 2018

What they said ⬆️

@jkaupp
Copy link

@jkaupp jkaupp commented Feb 3, 2018

What they all said ^

@smouksassi
Copy link

@smouksassi smouksassi commented Feb 5, 2018

thanks following well so far great way to let us look at the ggplot2 internals. would be good to give us some examples that help us see how the internals change as depending of our use case we might not have exposure to certain ways on how ggplot2 can be used.

@xvrdm
Copy link

@xvrdm xvrdm commented Feb 6, 2018

Thanks a lot for getting this started so quickly! Shall we submit pull request for typos? I am not sure if we can on private repos...

@JoGall
Copy link

@JoGall JoGall commented Feb 7, 2018

Thanks a lot for doing this -- a perfect format for learning something I've been meaning to for ages!

@jjchern
Copy link
Contributor

@jjchern jjchern commented Feb 12, 2018

Hey Bob, thanks for your effort in creating a supportive atmosphere within the R community. I wanted to let you know I built my first ggplot2 extension thanks to your tutorial, especially the suggestion on keeping a local copy of ggplot2. The package is also on CRAN now (it's my first CRAN package).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.