New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Easy labels with geom_bars when position="fill" or position="stack"" #43

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@hrbrmstr
Owner

hrbrmstr commented Nov 28, 2017

Reverts #15
The label positions are not accurate. I ran the examples:

ggplot(as.data.frame(Titanic)) +
  aes(x = Class, fill = Survived, weight = Freq) +
  geom_bar() + stat_stack_labels()
ggplot(as.data.frame(Titanic)) +
  aes(x = Class, fill = Survived, weight = Freq) +
  geom_bar() + geom_label(stat = "stack_labels")
ggplot(as.data.frame(Titanic)) +
  aes(x = Class, fill = Survived, weight = Freq) +
  geom_bar() + stat_stack_labels() + facet_grid(~Sex)
ggplot(as.data.frame(Titanic)) +
  aes(x = as.integer(Class), fill = Survived, weight = Freq) +
  geom_area(stat = "count") + stat_stack_labels()

And they don't seem to be where they should be.

@hrbrmstr hrbrmstr merged commit 617dac3 into master Nov 28, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@larmarange

This comment has been minimized.

Show comment
Hide comment
@larmarange

larmarange Nov 28, 2017

Contributor

Dear @hrbrmstr ,
I'm truly sorry. Due to some changes in recent versions of ggplot2, these functions had to be updated (cf. larmarange/JLutils@74af35d#diff-508ea6fd25e9fb23be63d54af4538628 , NB: I have a copy of these functions elsewhere).

However, I completely forgot to update the pull request (which was developed almost 1.5 year ago).

Do you want me to propose a new and updated pull request?

Best regards

Contributor

larmarange commented Nov 28, 2017

Dear @hrbrmstr ,
I'm truly sorry. Due to some changes in recent versions of ggplot2, these functions had to be updated (cf. larmarange/JLutils@74af35d#diff-508ea6fd25e9fb23be63d54af4538628 , NB: I have a copy of these functions elsewhere).

However, I completely forgot to update the pull request (which was developed almost 1.5 year ago).

Do you want me to propose a new and updated pull request?

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment