Failed download file remains #97

Open
SpiritQuaddicted opened this Issue Sep 14, 2014 · 3 comments

Comments

Projects
None yet
3 participants
Collaborator

SpiritQuaddicted commented Sep 14, 2014

If a download fails, the file will be kept in the download directory. If the user tries to install again, the file will be used and if it was incomplete the user will get an error message.

There should be an option to remove the broken file somehow.

What error does it give in that case?
I get something like "gzip stream error" in some maps. This may be the cause.

Collaborator

SpiritQuaddicted commented Sep 17, 2014

If I recall correctly something about a stream.

Collaborator

SpiritQuaddicted commented Aug 10, 2015

I thought about it and see no reason to keep a broken file. The QI does not resume downloads (and should not, based on filesize it has no way of knowing if the file has been replaced upstream or if it actually resumes).

It might be nice to verify the md5sum after downloading but generally we can trust that a download either succeeds or results in an error message. If error, then delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment