Ensure /etc/iscsi/initiatorname.iscsi has reproducible size #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size of ghost files is still stored in rpm headers to allow to reserve space for /boot/initrd and such Some background is in rpm-software-management/rpm#229 Without this patch, size of /etc/iscsi/initiatorname.iscsi randomly varied between 53 and 54 See https://reproducible-builds.org/ for why this matters.
|
I had already pushed your change to my local git repo, and now I've pushed it to github. So no need to merge this. If I hadn't already moved ahead, I'd be glad to take this version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Ensure /etc/iscsi/initiatorname.iscsi has reproducible size
Size of ghost files is still stored in rpm headers
to allow to reserve space for /boot/initrd and such.
Some background is in rpm-software-management/rpm#229
Without this patch, size of /etc/iscsi/initiatorname.iscsi randomly varied between 53 and 54, preventing us from producing bit-identical results every time.
See https://reproducible-builds.org/ for why this matters.