Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure /etc/iscsi/initiatorname.iscsi has reproducible size #8

Closed
wants to merge 1 commit into from

Conversation

@bmwiedemann
Copy link

commented Jul 19, 2019

Ensure /etc/iscsi/initiatorname.iscsi has reproducible size

Size of ghost files is still stored in rpm headers
to allow to reserve space for /boot/initrd and such.
Some background is in rpm-software-management/rpm#229

Without this patch, size of /etc/iscsi/initiatorname.iscsi randomly varied between 53 and 54, preventing us from producing bit-identical results every time.

See https://reproducible-builds.org/ for why this matters.

Ensure /etc/iscsi/initiatorname.iscsi has reproducible size
size of ghost files is still stored in rpm headers
to allow to reserve space for /boot/initrd and such
Some background is in rpm-software-management/rpm#229

Without this patch, size of /etc/iscsi/initiatorname.iscsi randomly varied between 53 and 54

See https://reproducible-builds.org/ for why this matters.
@gonzoleeman

This comment has been minimized.

Copy link
Collaborator

commented Jul 23, 2019

I had already pushed your change to my local git repo, and now I've pushed it to github. So no need to merge this. If I hadn't already moved ahead, I'd be glad to take this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.