Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PDO #8

Closed
PerfectSlayer opened this issue Dec 31, 2017 · 3 comments
Closed

Support PDO #8

PerfectSlayer opened this issue Dec 31, 2017 · 3 comments

Comments

@PerfectSlayer
Copy link

Hi @hrk

Due to the migration to PDO, the plug-in raise an error: Legacy connection.
I saw on the community forum you plan to port you add-on. Could you confirm this add-on will be maintained?
Do you need help for the port ? I also saw one commit to address the issue: schmidi@81242ba (I haven't tested it).

Thanks!

@hrk
Copy link
Owner

hrk commented Jan 21, 2018

Sorry for the late reply. I incorporated @schmidi's changes in a new 6ab5b92 as I couldn't understand how to merge a fork. The code is now ready and has been tested to work.

@hrk hrk closed this as completed Jan 21, 2018
@hrk
Copy link
Owner

hrk commented Jan 21, 2018

Note: for people running an old instance there is a separate branch called pre-pdo. This seemed easier to me than managing two APIs at the same time.

@schmidi
Copy link

schmidi commented Jan 21, 2018

@hrk Thanks for including my changes. The plugin works and gives no warnings with the new PDO class, nevertheless I suggest to refactor the queries as prepare methods are not correctly used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants