Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negetive volume of breps #204

Merged
merged 7 commits into from
Dec 25, 2021
Merged

Fix negetive volume of breps #204

merged 7 commits into from
Dec 25, 2021

Conversation

hrntsm
Copy link
Owner

@hrntsm hrntsm commented Nov 6, 2021

変更点

  • Brepの体積が負になる場合があったため、Brep の Flip メソッドを使って体積が負になる場合を回避した

対応するIssue番号

close #203

@hrntsm hrntsm changed the title Add brep.flip to avoid negetive volume Fix negetive volume of breps Nov 6, 2021
@hrntsm
Copy link
Owner Author

hrntsm commented Nov 7, 2021

Flip すると Invalid な Brep になったりしてうまく処理されないBrepが生まれてしまっているので引き続き調査

@codeclimate
Copy link

codeclimate bot commented Dec 25, 2021

Code Climate has analyzed commit 2500913 and detected 0 issues on this pull request.

View more on Code Climate.

@hrntsm hrntsm merged commit c9c15c0 into develop Dec 25, 2021
@hrntsm hrntsm deleted the Fix/negative-volume-brep branch December 25, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The volume of a part may become negative.
1 participant