Skip to content
Permalink
Browse files

Fix a bunch of inconsequential uninitialized variables

  • Loading branch information...
hrydgard committed Jun 17, 2019
1 parent 3791136 commit a0dc85a9d73109886295a3afc249631b32ecff49
@@ -346,7 +346,7 @@ namespace MIPSInt

int off = GetMatrixSide(sz) - 1;
u32 sprefixRemove = VFPU_ANY_SWIZZLE();
u32 sprefixAdd;
u32 sprefixAdd = 0;
switch ((op >> 16) & 0xF) {
case 3:
{
@@ -79,7 +79,7 @@ inline GPUDebugBufferFormat &operator |=(GPUDebugBufferFormat &lhs, const GPUDeb
}

struct GPUDebugBuffer {
GPUDebugBuffer() : alloc_(false), data_(NULL) {
GPUDebugBuffer() {
}

GPUDebugBuffer(void *data, u32 stride, u32 height, GEBufferFormat fmt, bool reversed = false)
@@ -100,22 +100,22 @@ struct GPUDebugBuffer {
: alloc_(false), data_((u8 *)data), stride_(stride), height_(height), fmt_(fmt), flipped_(false) {
}

GPUDebugBuffer(GPUDebugBuffer &&other) {
GPUDebugBuffer(GPUDebugBuffer &&other) noexcept {
alloc_ = other.alloc_;
data_ = other.data_;
height_ = other.height_;
stride_ = other.stride_;
flipped_ = other.flipped_;
fmt_ = other.fmt_;
other.alloc_ = false;
other.data_ = NULL;
other.data_ = nullptr;
}

~GPUDebugBuffer() {
Free();
}

GPUDebugBuffer &operator = (GPUDebugBuffer &&other) {
GPUDebugBuffer &operator = (GPUDebugBuffer &&other) noexcept {
if (this != &other) {
Free();
alloc_ = other.alloc_;
@@ -125,7 +125,7 @@ struct GPUDebugBuffer {
flipped_ = other.flipped_;
fmt_ = other.fmt_;
other.alloc_ = false;
other.data_ = NULL;
other.data_ = nullptr;
}

return *this;
@@ -164,12 +164,12 @@ struct GPUDebugBuffer {
private:
u32 PixelSize(GPUDebugBufferFormat fmt) const;

bool alloc_;
u8 *data_;
u32 stride_;
u32 height_;
bool alloc_ = false;
u8 *data_ = nullptr;
u32 stride_ = 0;
u32 height_ = 0;
GPUDebugBufferFormat fmt_;
bool flipped_;
bool flipped_ = false;
};

struct GPUDebugVertex {
@@ -246,8 +246,8 @@ class VulkanQueueRunner {

VulkanContext *vulkan_;

VkFramebuffer backbuffer_;
VkImage backbufferImage_;
VkFramebuffer backbuffer_ = VK_NULL_HANDLE;
VkImage backbufferImage_ = VK_NULL_HANDLE;

VkRenderPass backbufferRenderPass_ = VK_NULL_HANDLE;
VkRenderPass framebufferRenderPass_ = VK_NULL_HANDLE;
@@ -288,8 +288,8 @@ class VulkanRenderManager {
FrameData frameData_[VulkanContext::MAX_INFLIGHT_FRAMES];

// Submission time state
int curWidth_;
int curHeight_;
int curWidth_ = -1;
int curHeight_ = -1;
bool insideFrame_ = false;
VKRStep *curRenderStep_ = nullptr;
std::vector<VKRStep *> steps_;
@@ -310,7 +310,7 @@ class VulkanRenderManager {
};
std::vector<VkFramebuffer> framebuffers_;
std::vector<SwapchainImageData> swapchainImages_;
uint32_t swapchainImageCount_;
uint32_t swapchainImageCount_ = 0;
struct DepthBufferInfo {
VkFormat format = VK_FORMAT_UNDEFINED;
VkImage image = VK_NULL_HANDLE;
@@ -109,7 +109,7 @@ class PopupScreen : public UIDialogScreen {

class ListPopupScreen : public PopupScreen {
public:
ListPopupScreen(std::string title) : PopupScreen(title), showButtons_(false) {}
ListPopupScreen(std::string title) : PopupScreen(title) {}
ListPopupScreen(std::string title, const std::vector<std::string> &items, int selected, std::function<void(int)> callback, bool showButtons = false)
: PopupScreen(title, "OK", "Cancel"), adaptor_(items, selected), callback_(callback), showButtons_(showButtons) {
}
@@ -135,13 +135,13 @@ class ListPopupScreen : public PopupScreen {
virtual bool ShowButtons() const override { return showButtons_; }
virtual void CreatePopupContents(UI::ViewGroup *parent) override;
UI::StringVectorListAdaptor adaptor_;
UI::ListView *listView_;
UI::ListView *listView_ = nullptr;

private:
UI::EventReturn OnListChoice(UI::EventParams &e);

std::function<void(int)> callback_;
bool showButtons_;
bool showButtons_ = false;
std::set<int> hidden_;
};

@@ -169,7 +169,7 @@ namespace UI {
class SliderPopupScreen : public PopupScreen {
public:
SliderPopupScreen(int *value, int minValue, int maxValue, const std::string &title, int step = 1, const std::string &units = "")
: PopupScreen(title, "OK", "Cancel"), units_(units), value_(value), minValue_(minValue), maxValue_(maxValue), step_(step) {}
: PopupScreen(title, "OK", "Cancel"), units_(units), value_(value), minValue_(minValue), maxValue_(maxValue), step_(step) {}
virtual void CreatePopupContents(ViewGroup *parent) override;

void SetNegativeDisable(const std::string &str) {
@@ -185,8 +185,8 @@ class SliderPopupScreen : public PopupScreen {
EventReturn OnTextChange(EventParams &params);
EventReturn OnSliderChange(EventParams &params);
virtual void OnCompleted(DialogResult result) override;
Slider *slider_;
UI::TextEdit *edit_;
Slider *slider_ = nullptr;
UI::TextEdit *edit_ = nullptr;
std::string units_;
std::string negativeLabel_;
int *value_;
@@ -552,8 +552,8 @@ class Slider : public Clickable {
float paddingLeft_;
float paddingRight_;
int step_;
int repeat_;
int repeatCode_;
int repeat_ = 0;
int repeatCode_ = 0;
};

class SliderFloat : public Clickable {

0 comments on commit a0dc85a

Please sign in to comment.
You can’t perform that action at this time.