Permalink
Browse files

GPU: Consider bbox failed with zero verts.

This seems to match behavior in tests.
  • Loading branch information...
unknownbrackets committed Aug 20, 2017
1 parent 1cf5e30 commit d6506b3d5905299a08ea44e9a478ee966eb431ed
Showing with 7 additions and 5 deletions.
  1. +1 −2 GPU/GPUCommon.cpp
  2. +6 −3 GPU/Null/NullGpu.cpp
View
@@ -1543,8 +1543,7 @@ void GPUCommon::Execute_BoundingBox(u32 op, u32 diff) {
// Just resetting, nothing to check bounds for.
const u32 data = op & 0x00FFFFFF;
if (data == 0) {
// TODO: Should this set the bboxResult? Let's set it true for now.
currentList->bboxResult = true;
currentList->bboxResult = false;
return;
}
if (((data & 7) == 0) && data <= 64) { // Sanity check
View
@@ -96,10 +96,13 @@ void NullGPU::ExecuteOp(u32 op, u32 diff) {
break;
case GE_CMD_BOUNDINGBOX:
if (data != 0)
if (data != 0) {
DEBUG_LOG(G3D, "Unsupported bounding box: %06x", data);
// bounding box test. Let's assume the box was within the drawing region.
currentList->bboxResult = true;
// Bounding box test. Let's assume the box was within the drawing region.
currentList->bboxResult = true;
} else {
currentList->bboxResult = false;
}
break;
case GE_CMD_VERTEXTYPE:

0 comments on commit d6506b3

Please sign in to comment.