Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valkyria Chronicles 3 Extra Edition (ULJM0781):- Wrong allied and enemy base camp flag colours since v0.9.8-44-gdac51b9 #5738

Closed
solarmystic opened this Issue Mar 28, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@solarmystic
Copy link
Contributor

solarmystic commented Mar 28, 2014

Issue is as stated in the title. First actual responsible commit is v0.9.8-29-g162f229 162f229 by @unknownbrackets merged into master with v0.9.8-44-gdac51b9 dac51b9

Allied base camp flag is cyan in colour:-
29b

Uncaptured enemy camp flag is all black in colour:-
29

Last unaffected commit is v0.9.8-28-g246eaeb 246eaeb

28b

28

Reproduction method:-

  1. Load up the game using any revision from v0.9.8-44-gdac51b9 if you're incapable of self compiling. Otherwise, use git reset --hard 162f229, followed by a git submodule update --init, compile and run that build (v0.9.8-29-g162f229).
  2. Play any mission, and using any character, rotate the camera to face your base camp flag or head to any uncaptured enemy camp to view the issue.

Thanks to denslife16 from the ppsspp.org forums who first discovered the issue. This game was not in my test suite when I was doing overall game testing for #5693 which is why I didn't report it initially. My apologies.

@raven02

This comment has been minimized.

Copy link
Contributor

raven02 commented Mar 28, 2014

I think it is the color different , right ?

@solarmystic solarmystic changed the title Valkyria Chronicles 3 Extra Edition (ULJM0781):- Wrong base camp and enemy camp flag colours since v0.9.8-44-gdac51b9 Valkyria Chronicles 3 Extra Edition (ULJM0781):- Wrong allied base camp and enemy camp flag colours since v0.9.8-44-gdac51b9 Mar 28, 2014

@solarmystic solarmystic changed the title Valkyria Chronicles 3 Extra Edition (ULJM0781):- Wrong allied base camp and enemy camp flag colours since v0.9.8-44-gdac51b9 Valkyria Chronicles 3 Extra Edition (ULJM0781):- Wrong allied and enemy base camp flag colours since v0.9.8-44-gdac51b9 Mar 28, 2014

@solarmystic

This comment has been minimized.

Copy link
Contributor Author

solarmystic commented Mar 28, 2014

@raven02
You can see it for yourself in the pictures I posted, it's definitely not right at all. Amazingly, only those elements of the map are affected. The actual sky, characters, structures and vehicles aren't affected at all.

@raven02

This comment has been minimized.

Copy link
Contributor

raven02 commented Mar 28, 2014

I see the rect. flag color is different as well as the black color of the squ. flag .Not too sure if it is similar issue as Shining Ark .

@hrydgard

This comment has been minimized.

Copy link
Owner

hrydgard commented Mar 28, 2014

To find out which function is at fault, comment these lines out, only one at a time:

{&VertexDecoder::Step_Color8888Morph, &VertexDecoderJitCache::Jit_Color8888Morph},
{&VertexDecoder::Step_Color4444Morph, &VertexDecoderJitCache::Jit_Color4444Morph},
{&VertexDecoder::Step_Color565Morph, &VertexDecoderJitCache::Jit_Color565Morph},
{&VertexDecoder::Step_Color5551Morph, &VertexDecoderJitCache::Jit_Color5551Morph},

When it starts working again, we know which one of these to look closer at.

@solarmystic

This comment has been minimized.

Copy link
Contributor Author

solarmystic commented Mar 28, 2014

@hrydgard
Commenting out just {&VertexDecoder::Step_Color565Morph, &VertexDecoderJitCache::Jit_Color565Morph},
in
GPU/GLES/VertexDecoderX86.cpp
did the trick.

uljm05781_00000

So apparently that 565 function is to blame for the issue. The other lines didn't have any effect on the issue at all.

@hrydgard

This comment has been minimized.

Copy link
Owner

hrydgard commented Mar 28, 2014

Well it means that the bug is in the function Jit_Color565Morph, but yeah. @unknownbrackets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.