Error compiling with GCC-5.4 #9178

Closed
latot opened this Issue Dec 21, 2016 · 10 comments

Projects

None yet

4 participants

@latot
Contributor
latot commented Dec 21, 2016 edited

Hi, as the title says, i can't compile ppsspp with gcc-5.4:

In file included from /home/pipe/Documentos/git/ppsspp/ext/glslang/glslang/MachineIndependent/../Include/InfoSink.h:39:0,
                 from /home/pipe/Documentos/git/ppsspp/ext/glslang/glslang/MachineIndependent/intermOut.cpp:38:
/home/pipe/Documentos/git/ppsspp/ext/glslang/glslang/MachineIndependent/intermOut.cpp: En la función ‘bool {anónimo}::is_positive_infinity(double)’:
/home/pipe/Documentos/git/ppsspp/ext/glslang/glslang/MachineIndependent/intermOut.cpp:52:15: error: expected unqualified-id before ‘(’ token
   return std::isinf(x) && (x >= 0);

I use Gentoo 64.

Thx. Cya.

@hrydgard
Owner

another glslang bug? you've properly updated your submodules, right? if not it should be enough to rm -rf ext/glslang and then git submodule init --update --recursive.

Since we are now using upstream glslang, this should really be reported at https://github.com/KhronosGroup/glslang if it's still an issue.

@latot
Contributor
latot commented Dec 21, 2016

okis, i have the submodules updated, seems you have a little of experience with gslang bugs..

Linking!

KhronosGroup/glslang#642

Thx. Cya.

@Orphis
Collaborator
Orphis commented Dec 21, 2016

@hrydgard Actually, git submodule sync --recursive and then git submodule init --update --recursive are the proper commands!

@latot
Contributor
latot commented Dec 21, 2016

in my case i use git submodule update --recursive

@mrcmunir
Contributor
mrcmunir commented Dec 29, 2016 edited

@latot Add #include < cmath > in that file I compile fine with GCC5.4 compiler

Edit : In the actual submodule it's ok code maybbe you bad Sync?

@latot
Contributor
latot commented Dec 29, 2016

submodules are ok, reseted, rysync, etc...., and nice, that fix the issue!, updating upstream

@latot
Contributor
latot commented Dec 29, 2016

Hi, this issue is already fixed in upstream, @hrydgard is possible update gslang branch of ppsspp with upstream?, or just fix this?

in the last case is only change math.c to cmath

Thx. Cya

@hrydgard
Owner

Right, I'll update it. Thanks!

@hrydgard hrydgard added a commit that referenced this issue Dec 29, 2016
@hrydgard Update glslang (see #9178) 8ebb91b
@hrydgard
Owner

Done! Please reopen if there are still issues.

@hrydgard hrydgard closed this Dec 29, 2016
@latot
Contributor
latot commented Dec 29, 2016

Hi!, now works, Thx!

@pal1000 pal1000 pushed a commit to pal1000/ppsspp that referenced this issue Jan 5, 2017
@hrydgard + prodea2 Update glslang (see #9178) 0c9d303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment