Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove filename prefix for reducehashranges #14341

Merged
merged 1 commit into from Apr 17, 2021

Conversation

Banh-Canh
Copy link
Contributor

Hello, just fixing a small mistake of mine from #14332.

About adding the dimensions as a prefix for textures using a non-default reducehashvalue:
It was because I thought multiple differents reducehash value could create a mess with other textures that use the other values but it doesn't look like it.

I tried to be safe but I now realize that this way [reducehashranges] does not work with [hashes] (unless some changes are made) or at least, isn't intuitive since this won't work:

[hashes]
128x256_addresscluthash = images1.png

but this works (even though the dumped file is still named with the prefix):

[hashes]
addresscluthash = images1.png

So to correct my mistake (sorry), I simply removed the prefix I previously added which should fix that.

[reducehashranges]
;; doesn't do anything unless reduceHash = true
;; syntax : w,h = reducehashvalue
128,256 = 0.3125
[hashes]
;; dumped file using the reducehash value, the following still work and is coherent with the filename
addresscluthash = images1.png

Filenames will be back to: addresscluthash.png
Like all the others.

Double-checked how it would interact with [hashranges] and it looks ok (I don't think anyone is going to be using both though).

@hrydgard
Copy link
Owner

ok, that makes sense.

@hrydgard hrydgard added this to the v1.12.0 milestone Apr 17, 2021
@hrydgard hrydgard merged commit 73fb004 into hrydgard:master Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants