Split the main framebuffer in Killzone, to avoid texturing-from-current-rendertarget#15934
Merged
Split the main framebuffer in Killzone, to avoid texturing-from-current-rendertarget#15934
Conversation
Greatly improves performance. See issue #6207
hrydgard
changed the title
Owner
Author
|
Alright, the full effect is working now, and runs pretty fast. Some cleanup left to do (like getting rid of the matrix multiplication), but almost ready for review, so marking as such. |
Owner
Author
|
Alright, I'm pretty happy with it now, despite minor gross-ness. The results are great, and we don't really have a better way to deal with games that aggressively use the edge of the same framebuffer it's rendering to as heavily-used temporary storage. |
This was referenced Aug 31, 2022
hrydgard
commented
Aug 31, 2022
Comment on lines
+960
to
963
| if (matchInfo->yOffset < 0 && matchInfo->yOffset - minSubareaHeight <= 0) { | ||
| // Can't be inside the framebuffer. | ||
| return false; | ||
| } |
Owner
Author
There was a problem hiding this comment.
Screwed up the logic here, will fix tomorrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6207
Work-in-progress, need to verify that it's actually doing the effect right, and maybe can do the checks better.
There's no way around a compat.ini hack for this game, we just can't practically detect this situation in a generic way. But this approach does appear to work fine.
Additionally, tweaks ForceMax60Fps to work for the game and enables it, for more speed. Not sure if I should make a separate compat.ini flag for the tweak there.