Always do the vertex shader part of the fog computation. #16111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #16104, we drastically reduced the number of shader variants for games that use flexible lighting setups. I looked at a few games and it seems that a lot of games have the same shaders with fog on/off, while fog is super cheap to compute. So let's just always do it, reducing vertex shader variants further (though the amount of pipelines will probably remain the same, since we still specialize the fragment shader). Might also be worth adding a dynamic bool for the fragment shader, but if so, doing it separately.
| uint32_t colorWriteMask; float mipBias; | ||
| // Fragment data | ||
| float fogColor[4]; // .w is unused | ||
| float fogColor[4]; |
Collaborator
There was a problem hiding this comment.
Isn't this still true?
-[Unknown]
Owner
Author
There was a problem hiding this comment.
It is, it just wasn't in an intermediate stage of this PR :P I'll sneak in a revert of this line in some other thing later.
| _assert_(hasNormal); | ||
| } | ||
|
|
||
| bool enableFog = gstate.isFogEnabled() && !isModeThrough && !gstate.isModeClear(); |
Collaborator
There was a problem hiding this comment.
Just a note: if we remove the flag from the frag shader too, we just have to make sure it isn't enabled in clearMode (should be easy, already has a bit.) Note that clear can be used in transform mode.
-[Unknown]
Owner
Author
There was a problem hiding this comment.
Yup, so I noticed when I tried earlier today, and decided to not bother for now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #16104, we drastically reduced the number of shader variants for games that use flexible lighting setups.
I looked at a few games and it seems that a lot of games have the same shaders with fog on/off, while fog is super cheap to compute. So let's just always do it, reducing vertex shader variants further (though the amount of pipelines will probably remain the same, since we still specialize the fragment shader).
Might also be worth adding a dynamic bool for the fragment shader, but if so, doing it in a separate PR (or possibly set the fog coefficients so no fog is applied...)