GPU: Hook Gods Eater Burst avatar read #16184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, only with an explicit flag (not yet used.)
Currently not working since depth comes back as 0.
Currently, only used by one hook.
Owner
|
I have depth readback functionality hooked up for Vulkan in an old branch for the lens flare stuff, could try to get that part of it in later. |
hrydgard
approved these changes
Oct 9, 2022
Owner
|
Another thing, we should probably unify the naming of GPU readbacks a bit. "Pack" came from some OpenGL thingy, then we have "Download" and "Readback". Download feels a bit networky, maybe we should unify on Readback? |
Collaborator
Author
|
Yeah, that's fair. I think Readback is most unambiguous. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you start a new game of Gods Eater Burst, it draws your customized character, and makes a screenshot. This character shows on the loading screen, on the right side.
This has up to now only worked in the software renderer. This hooks the function so we know to download the color buffer and depth buffer (yes) it requires. It uses depth to "stencil out" and set the alpha in the image it saves (although... it saves as a JPEG so I didn't check where the alpha goes... it does 5551 in this func. But it definitely needs it, or it's transparent and not shown when loading.)
This uses the depth download from #11676 to make that work. Note that the character's colors look a bit funny without #16179.
Currently only works in GLES - the depth download just gets zeros elsewhere, so it doesn't work. Should work on mobile GLES, though.
-[Unknown]