softgpu: Correct linear interp for uneven positions #16241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the start coordinate was something like 51.75, we were incorrectly drawing to 51. This can be seen in the Metal Slug intro (hrydgard#15755.)
Can't round to the pixel when calculating the S/T deltas. This fixes issues in Wipeout (hrydgard#16131) and Call of Duty bloom.
This was referenced Oct 17, 2022
hrydgard
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the software renderer issues in #15755, as well as the text rendering in #16131. It also makes a frame dump from #11573 render bloom correctly (it was slightly off before.)
The triangle fan change doesn't change either of those, but I noticed a rectangle that was still triangles and so handled more generically.
-[Unknown]