Preserve framebuffer on pause screen even if render resolution is changed #16409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
approved these changes
Nov 22, 2022
| BuildReportingInfo(); | ||
| framebufferManager_->Resized(); | ||
| drawEngineCommon_->NotifyConfigChanged(); | ||
| shaderManager_->DirtyLastShader(); // Don't think this is needed, at all. |
Collaborator
There was a problem hiding this comment.
Agreed, must be a bug somewhere else if it is. I think it's just come along for the ride through various refactoring since we only had a GLES backend...
-[Unknown]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #16404.
Reduces the cases where the pause screen will end up with a black background, by separating these different state change checks.