Vulkan: Use stencil export when available #16434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just being safe.
This prevents multiple passes to upload stencil buffers.
Also corrects handling of non-24 bit depth when reducing the range.
hrydgard
approved these changes
Nov 25, 2022
Owner
hrydgard
left a comment
hrydgard
left a comment
There was a problem hiding this comment.
Yeah, why not. It's a shame though that NV still hasn't implemented support for this in their hardware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also on desktop OpenGL. In both cases, an extension exists to allow directly writing to stencil.
This has been showing up as supported on some newer Adreno devices (7xx, etc.) and should be more efficient than the previous 8 pass method. Not supported on NVIDIA, but I tested on an Intel GPU.
A small optimization, but it was easy.
-[Unknown]