Fix a race condition during Vulkan shader cache load.#16804
Merged
Conversation
Could lead to unnecessary pipelines being created.
hrydgard
force-pushed
the
fix-pipeline-cache-race-condition
branch
from
b4ff8d1 to
784e8ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Race condition in VulkanRenderManager::CreateGraphicsPipeline, due to the async cache load.
Could lead to unnecessary pipelines being created (pipelines for backbuffer, even when using buffered rendering).
Was seeing mystifying pipelines created while doing some logging investigating #16802 ...