Vulkan texture uploads: Take optimalBufferCopyRowPitchAlignment into account #17052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int bpp = VkFormatBytesPerPixel(actualFmt); | ||
| int stride = (mipWidth * bpp + 15) & ~15; // output stride | ||
| int uploadSize = stride * mipHeight; | ||
| int optimalStrideAlignment = std::max(4, (int)vulkan->GetPhysicalDeviceProperties().properties.limits.optimalBufferCopyRowPitchAlignment); |
Collaborator
There was a problem hiding this comment.
This isn't actually used? Shouldn't we have int byteStride = std::max(optimalStrideAlignment, RoundUpToPowerOf2(mipWidth * bpp)); or something (more complex if it wouldn't always be a power of two)?
-[Unknown]
Owner
Author
There was a problem hiding this comment.
Ugh, it was supposed to be passed in as the second parameter in RoundUpToPower2 (there's now a verison that takes that, which is useful sometimes). I think it's guaranteed to be a power of two, I don't see any non-pow2 values in vulkan.gpuinfo.org either.
…account Might marginally increase texture upload performance on some GPUs, but mainly just the right thing to do. For example, on Intel, this is 64.
hrydgard
force-pushed
the
use-optimal-image-stride
branch
from
33b4600 to
cc9c01b
Compare
unknownbrackets
approved these changes
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just something I noticed we didn't do, while poking around the texture code.
Might marginally increase texture upload performance on some GPUs, but mainly just the right thing to do.
For example, on Intel, this is 64.