GPU: Correct depth clip/cull for zero scale#17055
Merged
hrydgard merged 1 commit intohrydgard:masterfrom Mar 5, 2023
Merged
Conversation
Owner
|
Yeah, this should be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16992. We had -INF and other problems in the clip distance and cull distance formulas, because zero depth scale was factored in.
This essentially disables depth culling when depth viewport scale is set to zero, which might technically be wrong. That said, I've seen very few games set the scale to zero and I don't want to add more uniforms and matrix multiplies to get the original depth. Software is accurate here.
-[Unknown]