Tales of Phantasia - Narikiri Dungeon X: Avoid some GPU readbacks. #17181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copies to a framebuffer instead of RAM. Confirmed through e-mail that is fixes the performance drop from #16714, but unknown whether there are any regressions in the rest of the game. I guess we'll find out.
hrydgard
added
GE emulation
Collaborator
|
Trivially, this appears to break save icons of course, which are now black (or could be whatever was last in that RAM, I guess.) It may have also broken the desert screen shimmering effect, but I thought that was intra-block transfers so it was probably broken by something else. -[Unknown] |
Owner
Author
|
Ah. Well I didn't get responses about those from my tester, so there we go. Might be able to do something horribly game specific with the size of the copies. but considering reverting. |
Collaborator
|
Well, we actually hook the save icon func (see #6263.) Probably at least where we know these funcs downscale or do other CPU operations, we could add a flag. I don't know what else might happen, this game has other effects in places and does some weird things... -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies to a framebuffer instead of RAM.
Confirmed through e-mail that is fixes the performance drop from #16714, but unknown whether there are any regressions in the rest of the game.
I guess we'll find out.
Fixes #16714.