CHD: Fix unnecessary reloads of "hunks" during large reads - #18931
Merged
Conversation
hrydgard
force-pushed
the
chd-hunk-size-fix
branch
from
March 16, 2024 19:52
3e25655 to
d284ad4
Compare
Collaborator
|
They say it's about file size, but it really differs a lot between games and in most cases 2048 produces smaller size, so the argument is just silly. |
Owner
Author
|
Well, either way, we had a bug, so fixing it. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the worst performance problem of using large hunk sizes with CHDs in PPSSPP.
It seems that with this, performance is good enough that we can remove the warning for bad CHDs, but I still recommend 2048-byte hunk size and will continue to do so in the website instructions.
Fixes #18925