Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat UV gen mode 3 as GE_TEXMAP_TEXTURE_COORDS. #3243

Merged
merged 2 commits into from Aug 19, 2013

Conversation

Projects
None yet
3 participants
@unknownbrackets
Copy link
Collaborator

commented Aug 19, 2013

Fixes #2214 (Riviera.) Finally found the bugger.

Also checked what JPCSP did for this value and they seem to treat it as coords as well. I'm not sure what it means, maybe could log it...

Shouldn't really be likely to break anything...

-[Unknown]

@raven02

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2013

Another nice fix . Just wonder do we need to take care the HW T&L as well ?

@unknownbrackets

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 19, 2013

Oh, hmm, right. Hold on.

-[Unknown]

@hrydgard

This comment has been minimized.

Copy link
Owner

commented Aug 19, 2013

Another nice catch :)

Use constants for other uv gen mode usages.
And also change them to treat 3 as coords as well.
@unknownbrackets

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 19, 2013

I've added it to the other places and tried a few games, none were really affected. So far I haven't seen much using that mode, so I hope it's safe.

-[Unknown]

@hrydgard

This comment has been minimized.

Copy link
Owner

commented Aug 19, 2013

Seems most likely to be a bug in the game as I'm pretty sure only the first 3 UV generation types are defined. So it should be safe.

hrydgard added a commit that referenced this pull request Aug 19, 2013

Merge pull request #3243 from unknownbrackets/uv-gen
Treat UV gen mode 3 as GE_TEXMAP_TEXTURE_COORDS.

@hrydgard hrydgard merged commit 61d2042 into hrydgard:master Aug 19, 2013

@unknownbrackets unknownbrackets deleted the unknownbrackets:uv-gen branch Aug 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.