Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game loading: Fix a bug and prevent a "file is corrupt" error for demos/np PBPs that really aren't corrupt. #3550

Merged
merged 1 commit into from Sep 1, 2013

Conversation

thedax
Copy link
Collaborator

@thedax thedax commented Sep 1, 2013

Fixes #3328. Also fixes a black screen that would occur if you drop a blank directory onto PPSSPP.

@unknownbrackets
Copy link
Collaborator

Hmm, bootingTheGame looks very questionable. Given that EBOOT.PBP is known to exist in that code path, what are you expecting Identify_File((filename + "/EBOOT.PBP"), bootingTheGame); to return other than FILETYPE_PSP_ISO_NP?

-[Unknown]

@thedax
Copy link
Collaborator Author

thedax commented Sep 1, 2013

Nothing different, but I can just set it to true I guess. However, for other places, it seems to be expecting the directory type to be returned, otherwise it doesn't seem to pull icon0.png from the eboot, resulting in a gray rectangle instead of the demo's icon. Did I miss something obvious that would cause it not to get the icon? Hm..

@thedax
Copy link
Collaborator Author

thedax commented Sep 1, 2013

I think I misunderstood you. If you don't check what kind of eboot it is, PPSSPP will say it's corrupt since it'll try to run it as a directory game(and thus treat EBOOT.PBP as a regular eboot), using the VirtualDiscFileSystem, when it clearly isn't supposed to.

@thedax
Copy link
Collaborator Author

thedax commented Sep 1, 2013

Rewritten to be much cleaner.

hrydgard added a commit that referenced this pull request Sep 1, 2013
Game loading: Fix a bug and prevent a "file is corrupt" error for demos/np PBPs that really aren't corrupt.
@hrydgard hrydgard merged commit cfbf83e into hrydgard:master Sep 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants