Use a delay to approximate timing of savedata status changes #5368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested to require this exact version to return that error. Not sure if any games will actually hit this anyway, but they did with lower SDK versions.
This is probably more based on IO (maybe even loading and unloading the module for the dialog or something?) but time should approximate it. May improve games not expecting the status to switch right away.
This was referenced Feb 8, 2014
|
To get this perfectly accurate we'd probably have to write it as MIPS code very closely to the real stuff and run it in PSP threads the same way. This should be a decent enough approximation one would hope... and you made it nicely tweakable. |
hrydgard
added a commit
that referenced
this pull request
Feb 8, 2014
Use a delay to approximate timing of savedata status changes
|
Mentioning #5319 to get a link in that issue. |
This was referenced Feb 8, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timing based on tests, but it seems to vary, and thread priority greatly affects it. I'm hoping this will work well enough.
May improve the games that have problems when the status changes immediately or when they wait to check the status and expect it to have already changed.
-[Unknown]