New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in Sol Trigger with atrac/sas #8192

Merged
merged 4 commits into from Nov 8, 2015

Conversation

Projects
None yet
2 participants
@unknownbrackets
Collaborator

unknownbrackets commented Nov 8, 2015

This isn't well tested, but all these changes make sense.

With these changes, the sound effects, voices, etc. all sound right to me in Sol Trigger - and reverb definitely improves things here (with this echo thing.) Voices are super quiet, still, although for me they also seem pretty quiet on a real PSP too (not retested recently since my PSP screen is ruined.)

Fixes #8186, but #6511 is still an issue if the cutscene is skipped.

-[Unknown]

unknownbrackets added some commits Nov 8, 2015

Atrac: Also read loop count from context RAM.
Observed the Sol Trigger demo's library writing values here, although in
the cases I saw it wasn't changing it from 0.
Atrac: Handle SAS end the same way as other types.
It makes sense to match, and this sounds right in Sol Trigger.  Haven't
tested in detail yet, but it should prevent cutting off sounds.
Atrac: Use fileoffset for curOff context value.
This doesn't match my tests so far, but Sol Trigger works correctly this
way.  Since this value is primarily only used for SAS, changing it back
for now until more thoroughly testing SAS makes sense.
Sas: Reduce ECHO effect repeat level.
Previously, it sounded horrible in Sol Trigger - can be observed in
tutorial boxes when going into battle, for example, and also several other
effects.  Halving this value sounds a lot more correct.

It's not clear what value exactly is correct.

hrydgard added a commit that referenced this pull request Nov 8, 2015

Merge pull request #8192 from unknownbrackets/atrac-sas
Fix issues in Sol Trigger with atrac/sas

@hrydgard hrydgard merged commit 9462bf3 into hrydgard:master Nov 8, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@unknownbrackets unknownbrackets deleted the unknownbrackets:atrac-sas branch Nov 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment