Henry Saputra hsaputra

hsaputra commented on pull request apache/flink#711
@hsaputra

Thanks for the review @StephanEwen , that what I was suspecting =) Will commence with merge ...

hsaputra commented on pull request apache/flink#711
@hsaputra

Thanks @rmetzger for the review. Will merge this EOD tomorrow if no objection.

hsaputra commented on pull request apache/incubator-twill#34
@hsaputra

+1 LGTM

hsaputra commented on pull request apache/incubator-twill#34
@hsaputra

Ah ok, thanks!

hsaputra commented on pull request apache/incubator-twill#34
@hsaputra

Since the latch is created per thread, what is the latch used for?

hsaputra commented on pull request apache/flink#711
@hsaputra

CC @StephanEwen I think that could be expressed via right name or additional comments rather than using all caps.

hsaputra deleted branch add_2015_copyright at hsaputra/cdap-apps
hsaputra opened pull request caskdata/cdap-apps#87
@hsaputra
Add 2014-2015 copyright to the README file.
1 commit with 1 addition and 1 deletion
hsaputra opened pull request apache/flink#711
@hsaputra
Change FlinkMiniCluster#HOSTNAME to FlinkMiniCluster#hostname to match naming convention.
1 commit with 7 additions and 7 deletions
@hsaputra
hsaputra commented on pull request apache/flink#695
@hsaputra

Add one more small request to add comments as JavaDoc for the test then it should ready to go. Thanks again for the contribution.

hsaputra commented on pull request apache/flink#695
@hsaputra

Could you add JavaDoc comment on what is needed to run this test and kind of small description why it is not part of JUnit test for now.

hsaputra commented on pull request apache/flink#695
@hsaputra

Sounds good to me

@hsaputra
  • @ajainarayanan a9f5a2c
    Modifies workers feature to use my-start-stop-button to start/stop a …
  • @ajainarayanan 761eb54
    Makes prefernces confiurable through directive attributes
  • 160 more commits »
hsaputra commented on pull request apache/flink#695
@hsaputra

We are using JUnit for our tests so it would be great to convert this to JUnit style of test class.

hsaputra commented on pull request apache/flink#695
@hsaputra

Could you remove @author javadoc annotation?

hsaputra deleted branch wrap_very_long_line_in_FlatMapOperator at hsaputra/flink
hsaputra commented on pull request apache/flink#683
@hsaputra

Thanks all, merging ...

hsaputra commented on pull request apache/flink#683
@hsaputra

If no comment, will merge this simple fix end of day tomorrow.

hsaputra opened pull request apache/flink#683
@hsaputra
Wrap very long line in FlatMapOperator class
1 commit with 2 additions and 1 deletion
hsaputra commented on pull request apache/flink#664
@hsaputra

Hi @rmetzger, just did a pass and other than comments about unused test and broken Travis due to check style I think this PR is ready to go. +1

hsaputra commented on pull request apache/flink#664
@hsaputra

Do you want to keep this test as optional? If yes then it is better to have comments on why and when to uncomment this test. Otherwise, let's just …

hsaputra commented on pull request apache/flink#664
@hsaputra

Thanks for clarifying, Robert. I think convention to expect *Util classes to just contain static methods instead of being created as an instance. M…