Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tooltip][TooltipWithBounds] don't pass getRects to Tooltip #290

Merged
merged 1 commit into from May 15, 2018

Conversation

Projects
None yet
2 participants
@williaster
Copy link
Collaborator

commented May 15, 2018

馃悰 Bug Fix

Fixes #289 by not passing the getRects func prop from withBoundingRects to Tooltip.

Tested locally to ensure we no longer get the React error reported (React does not recognize the 'getRects' prop on a DOM element)

cc @emepyc

@hshoff hshoff added this to the v0.0.163 milestone May 15, 2018

@hshoff

This comment has been minimized.

Copy link
Owner

commented May 15, 2018

LGTM

@hshoff hshoff merged commit 6b6da7a into hshoff:master May 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.