Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Pie /> Allow null sort callbacks #327

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Projects
None yet
2 participants
@Gosha
Copy link
Contributor

commented Jul 25, 2018

pie.sortValues(null) turns off the default sorting, but before this PR pie.sort was never called with a null value. Hopefully this isn't a breaking change.

馃悰 Bug Fix

  • <Pie pieSort={null} pieSortValues={null} /> isn't ignored
@hshoff

hshoff approved these changes Jul 25, 2018

Copy link
Owner

left a comment

LGTM, thank you for the contribution!

@hshoff hshoff added this to the v0.0.171 milestone Jul 25, 2018

@hshoff hshoff merged commit 4ad36dd into hshoff:master Jul 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hshoff

This comment has been minimized.

Copy link
Owner

commented Aug 7, 2018

Sorry for the delay! just published https://github.com/hshoff/vx/releases/tag/v0.0.171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.