Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TooltipWithBounds types do not have the new unstyled props #691

Closed
tbassetto opened this issue May 12, 2020 · 1 comment · Fixed by #721
Closed

TooltipWithBounds types do not have the new unstyled props #691

tbassetto opened this issue May 12, 2020 · 1 comment · Fixed by #721
Labels
🚀enhancement 👋 help wanted

Comments

@tbassetto
Copy link

tbassetto commented May 12, 2020 •
edited
Loading

The <TooltipWithBounds /> component redefines TooltipProps instead of inheriting it from <Toolip/> and thus TypeScript is complaining that it doesn't recognize unstyled.
@tbassetto tbassetto changed the title TooltipWithBounds doesn't have the new unstyled props TooltipWithBounds types do not have the new unstyled props May 12, 2020
@williaster
Copy link
Collaborator

Thanks for flagging this @tbassetto. I'm happy to review a PR if you/others are up for it.

I think to fix it properly we'd need to not just inherit the types from Tooltip, but remove the styles set by TooltipWithBounds and instead pass top and left to Tooltip so it can handle the merging of styles or not applying them if unstyled is set.

@dennisja dennisja mentioned this issue May 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚀enhancement 👋 help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tooltip with bounds dennisja/vx
2 participants
@tbassetto @williaster